* [PATCH linux-next] drm/i915: Remove redundant assignments
@ 2021-10-18 9:09 luo penghao
0 siblings, 0 replies; only message in thread
From: luo penghao @ 2021-10-18 9:09 UTC (permalink / raw)
To: Jani Nikula
Cc: Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter,
Stephen Rothwell, intel-gfx, dri-devel, linux-kernel,
penghao luo, Zeal Robot
From: penghao luo <luo.penghao@zte.com.cn>
The assignment of variables will be overwritten later, so the
assignment here is meaningless.
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/gem/i915_gem_userptr.c:291: warning:
Although the value stored to 'ret' is used in the enclosing expression,
the value is never actually read from 'ret’.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: penghao luo <luo.penghao@zte.com.cn>
---
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index 8ea0fa6..f6f944d 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -288,7 +288,7 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj)
if (!i915_gem_object_is_readonly(obj))
gup_flags |= FOLL_WRITE;
- pinned = ret = 0;
+ pinned = 0;
while (pinned < num_pages) {
ret = pin_user_pages_fast(obj->userptr.ptr + pinned * PAGE_SIZE,
num_pages - pinned, gup_flags,
--
2.15.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-18 9:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 9:09 [PATCH linux-next] drm/i915: Remove redundant assignments luo penghao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).