* [PATCH] media: hi846: depend on OF
@ 2021-10-18 9:58 Martin Kepplinger
2021-10-18 13:42 ` [PATCH v2] " Martin Kepplinger
0 siblings, 1 reply; 3+ messages in thread
From: Martin Kepplinger @ 2021-10-18 9:58 UTC (permalink / raw)
To: mchehab
Cc: sakari.ailus, linux-media, linux-kernel, kernel,
paul.kocialkowski, Martin Kepplinger
Since other device enumerate mechanisms are currently not implemented,
make the hi846 sensor driver depend on CONFIG_OF.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 0e56489c97fb..53268f1f761f 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -746,6 +746,7 @@ config VIDEO_HI556
config VIDEO_HI846
tristate "Hynix Hi-846 sensor support"
depends on I2C && VIDEO_V4L2
+ depends on OF
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] media: hi846: depend on OF
2021-10-18 9:58 [PATCH] media: hi846: depend on OF Martin Kepplinger
@ 2021-10-18 13:42 ` Martin Kepplinger
2021-10-19 12:27 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Martin Kepplinger @ 2021-10-18 13:42 UTC (permalink / raw)
To: martin.kepplinger
Cc: kernel, linux-kernel, linux-media, mchehab, paul.kocialkowski,
sakari.ailus, kernel test robot
Since other device enumerate mechanisms are currently not implemented,
make the hi846 sensor driver depend on CONFIG_OF.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reported-by: kernel test robot <lkp@intel.com>
---
revision history
----------------
v2:
* added the reported-by tag
v1:
https://lore.kernel.org/linux-media/20211018095859.255912-1-martin.kepplinger@puri.sm/
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 0e56489c97fb..53268f1f761f 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -746,6 +746,7 @@ config VIDEO_HI556
config VIDEO_HI846
tristate "Hynix Hi-846 sensor support"
depends on I2C && VIDEO_V4L2
+ depends on OF
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: hi846: depend on OF
2021-10-18 13:42 ` [PATCH v2] " Martin Kepplinger
@ 2021-10-19 12:27 ` Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2021-10-19 12:27 UTC (permalink / raw)
To: Martin Kepplinger
Cc: kernel, linux-kernel, linux-media, mchehab, paul.kocialkowski,
kernel test robot
Hi Martin,
On Mon, Oct 18, 2021 at 03:42:46PM +0200, Martin Kepplinger wrote:
> Since other device enumerate mechanisms are currently not implemented,
> make the hi846 sensor driver depend on CONFIG_OF.
As far as I understand, this should work on ACPI based systems with just
of_match_ptr() macro removed.
In any case, linux/of_graph.h header should be replaced with
linux/property.h.
How about that instead?
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-19 12:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 9:58 [PATCH] media: hi846: depend on OF Martin Kepplinger
2021-10-18 13:42 ` [PATCH v2] " Martin Kepplinger
2021-10-19 12:27 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).