* [PATCH v3] crypto: s5p-sss - Add error handling in s5p_aes_probe()
@ 2021-10-21 1:34 Tang Bin
2021-10-29 13:11 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-10-21 1:34 UTC (permalink / raw)
To: krzysztof.kozlowski, vz, herbert, davem
Cc: linux-crypto, linux-samsung-soc, linux-kernel, Tang Bin, stable
The function s5p_aes_probe() does not perform sufficient error
checking after executing platform_get_resource(), thus fix it.
Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos")
Cc: <stable@vger.kernel.org>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Changes from v2
- add Cc: <stable@vger.kernel.org>
Changes from v1
- add fixed title
---
drivers/crypto/s5p-sss.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 55aa3a711..7717e9e59 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev)
variant = find_s5p_sss_version(pdev);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -EINVAL;
/*
* Note: HASH and PRNG uses the same registers in secss, avoid
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] crypto: s5p-sss - Add error handling in s5p_aes_probe()
2021-10-21 1:34 [PATCH v3] crypto: s5p-sss - Add error handling in s5p_aes_probe() Tang Bin
@ 2021-10-29 13:11 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-10-29 13:11 UTC (permalink / raw)
To: Tang Bin
Cc: krzysztof.kozlowski, vz, davem, linux-crypto, linux-samsung-soc,
linux-kernel, stable
On Thu, Oct 21, 2021 at 09:34:22AM +0800, Tang Bin wrote:
> The function s5p_aes_probe() does not perform sufficient error
> checking after executing platform_get_resource(), thus fix it.
>
> Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Changes from v2
> - add Cc: <stable@vger.kernel.org>
>
> Changes from v1
> - add fixed title
> ---
> drivers/crypto/s5p-sss.c | 2 ++
> 1 file changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-29 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 1:34 [PATCH v3] crypto: s5p-sss - Add error handling in s5p_aes_probe() Tang Bin
2021-10-29 13:11 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).