* [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove
@ 2021-10-21 3:14 Dongliang Mu
2021-10-21 6:58 ` Jon Hunter
2021-10-25 4:36 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Dongliang Mu @ 2021-10-21 3:14 UTC (permalink / raw)
To: Laxman Dewangan, Jon Hunter, Vinod Koul, Thierry Reding
Cc: Dongliang Mu, dmaengine, linux-tegra, linux-kernel
Since pm_runtime_put is done when tegra_adma_probe is successful, we
cannot do pm_runtime_put_sync again in tegra_adma_remove.
Fix this by removing the pm_runtime_put_sync in tegra_adma_remove.
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
drivers/dma/tegra210-adma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
index b1115a6d1935..7e4d40cd9577 100644
--- a/drivers/dma/tegra210-adma.c
+++ b/drivers/dma/tegra210-adma.c
@@ -940,7 +940,6 @@ static int tegra_adma_remove(struct platform_device *pdev)
for (i = 0; i < tdma->nr_channels; ++i)
irq_dispose_mapping(tdma->channels[i].irq);
- pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove
2021-10-21 3:14 [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove Dongliang Mu
@ 2021-10-21 6:58 ` Jon Hunter
2021-10-25 4:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2021-10-21 6:58 UTC (permalink / raw)
To: Dongliang Mu, Laxman Dewangan, Vinod Koul, Thierry Reding
Cc: dmaengine, linux-tegra, linux-kernel
On 21/10/2021 04:14, Dongliang Mu wrote:
> Since pm_runtime_put is done when tegra_adma_probe is successful, we
> cannot do pm_runtime_put_sync again in tegra_adma_remove.
>
> Fix this by removing the pm_runtime_put_sync in tegra_adma_remove.
>
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> drivers/dma/tegra210-adma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index b1115a6d1935..7e4d40cd9577 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -940,7 +940,6 @@ static int tegra_adma_remove(struct platform_device *pdev)
> for (i = 0; i < tdma->nr_channels; ++i)
> irq_dispose_mapping(tdma->channels[i].irq);
>
> - pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
>
> return 0;
>
Thanks!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove
2021-10-21 3:14 [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove Dongliang Mu
2021-10-21 6:58 ` Jon Hunter
@ 2021-10-25 4:36 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-10-25 4:36 UTC (permalink / raw)
To: Dongliang Mu
Cc: Laxman Dewangan, Jon Hunter, Thierry Reding, dmaengine,
linux-tegra, linux-kernel
On 21-10-21, 11:14, Dongliang Mu wrote:
> Since pm_runtime_put is done when tegra_adma_probe is successful, we
> cannot do pm_runtime_put_sync again in tegra_adma_remove.
>
> Fix this by removing the pm_runtime_put_sync in tegra_adma_remove.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 4:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 3:14 [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove Dongliang Mu
2021-10-21 6:58 ` Jon Hunter
2021-10-25 4:36 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).