* [PATCH] riscv: do not select non-existing config ANON_INODES
@ 2021-10-22 6:15 Lukas Bulwahn
2021-10-22 9:53 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2021-10-22 6:15 UTC (permalink / raw)
To: Anup Patel, Atish Patra, Paul Walmsley, Palmer Dabbelt,
Albert Ou, kvm, kvm-riscv, linux-riscv
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects
the config ANON_INODES in config KVM, but the config ANON_INODES is removed
since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.
Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:
ANON_INODES
Referencing files: arch/riscv/kvm/Kconfig
Remove selecting the non-existing config ANON_INODES.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/riscv/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index a712bb910cda..f5a342fa1b1d 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -22,7 +22,6 @@ config KVM
depends on RISCV_SBI && MMU
select MMU_NOTIFIER
select PREEMPT_NOTIFIERS
- select ANON_INODES
select KVM_MMIO
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select HAVE_KVM_VCPU_ASYNC_IOCTL
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] riscv: do not select non-existing config ANON_INODES
2021-10-22 6:15 [PATCH] riscv: do not select non-existing config ANON_INODES Lukas Bulwahn
@ 2021-10-22 9:53 ` Paolo Bonzini
2021-10-22 11:55 ` Anup Patel
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2021-10-22 9:53 UTC (permalink / raw)
To: Lukas Bulwahn, Anup Patel, Atish Patra, Paul Walmsley,
Palmer Dabbelt, Albert Ou, kvm, kvm-riscv, linux-riscv
Cc: kernel-janitors, linux-kernel
On 22/10/21 08:15, Lukas Bulwahn wrote:
> Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects
> the config ANON_INODES in config KVM, but the config ANON_INODES is removed
> since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.
>
> Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:
>
> ANON_INODES
> Referencing files: arch/riscv/kvm/Kconfig
>
> Remove selecting the non-existing config ANON_INODES.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> arch/riscv/kvm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
> index a712bb910cda..f5a342fa1b1d 100644
> --- a/arch/riscv/kvm/Kconfig
> +++ b/arch/riscv/kvm/Kconfig
> @@ -22,7 +22,6 @@ config KVM
> depends on RISCV_SBI && MMU
> select MMU_NOTIFIER
> select PREEMPT_NOTIFIERS
> - select ANON_INODES
> select KVM_MMIO
> select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> select HAVE_KVM_VCPU_ASYNC_IOCTL
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] riscv: do not select non-existing config ANON_INODES
2021-10-22 9:53 ` Paolo Bonzini
@ 2021-10-22 11:55 ` Anup Patel
0 siblings, 0 replies; 3+ messages in thread
From: Anup Patel @ 2021-10-22 11:55 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Lukas Bulwahn, Anup Patel, Atish Patra, Paul Walmsley,
Palmer Dabbelt, Albert Ou, KVM General, kvm-riscv, linux-riscv,
kernel-janitors, linux-kernel@vger.kernel.org List
On Fri, Oct 22, 2021 at 3:24 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 22/10/21 08:15, Lukas Bulwahn wrote:
> > Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects
> > the config ANON_INODES in config KVM, but the config ANON_INODES is removed
> > since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.
> >
> > Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:
> >
> > ANON_INODES
> > Referencing files: arch/riscv/kvm/Kconfig
> >
> > Remove selecting the non-existing config ANON_INODES.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > arch/riscv/kvm/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
> > index a712bb910cda..f5a342fa1b1d 100644
> > --- a/arch/riscv/kvm/Kconfig
> > +++ b/arch/riscv/kvm/Kconfig
> > @@ -22,7 +22,6 @@ config KVM
> > depends on RISCV_SBI && MMU
> > select MMU_NOTIFIER
> > select PREEMPT_NOTIFIERS
> > - select ANON_INODES
> > select KVM_MMIO
> > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > select HAVE_KVM_VCPU_ASYNC_IOCTL
> >
>
> Queued, thanks.
Thanks Paolo for applying this directly.
Regards,
Anup
>
> Paolo
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-22 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 6:15 [PATCH] riscv: do not select non-existing config ANON_INODES Lukas Bulwahn
2021-10-22 9:53 ` Paolo Bonzini
2021-10-22 11:55 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).