linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dmaengine: at_xdmac: fix compilation warning
@ 2021-10-25  7:40 Claudiu Beznea
  2021-10-25  8:34 ` Tudor.Ambarus
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Claudiu Beznea @ 2021-10-25  7:40 UTC (permalink / raw)
  To: ludovic.desroches, tudor.ambarus, vkoul
  Cc: claudiu.beznea, linux-arm-kernel, dmaengine, linux-kernel,
	kernel test robot

Fixed "unused variable 'atmel_xdmac_dev_pm_ops'" compilation warning
when CONFIG_PM is not defined.

Fixes: 8e0c7e486014 ("dmaengine: at_xdmac: use pm_ptr()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 drivers/dma/at_xdmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 7fb19bd18ac3..f5d053df66a5 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -2207,7 +2207,7 @@ static int at_xdmac_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static const struct dev_pm_ops atmel_xdmac_dev_pm_ops = {
+static const struct dev_pm_ops __maybe_unused atmel_xdmac_dev_pm_ops = {
 	.prepare	= atmel_xdmac_prepare,
 	SET_LATE_SYSTEM_SLEEP_PM_OPS(atmel_xdmac_suspend, atmel_xdmac_resume)
 };
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmaengine: at_xdmac: fix compilation warning
  2021-10-25  7:40 [PATCH] dmaengine: at_xdmac: fix compilation warning Claudiu Beznea
@ 2021-10-25  8:34 ` Tudor.Ambarus
  2021-10-28 17:22 ` Vinod Koul
  2021-12-08 10:41 ` Nicolas Ferre
  2 siblings, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2021-10-25  8:34 UTC (permalink / raw)
  To: Claudiu.Beznea, Ludovic.Desroches, vkoul
  Cc: linux-arm-kernel, dmaengine, linux-kernel, lkp

On 10/25/21 10:40 AM, Claudiu Beznea wrote:
> Fixed "unused variable 'atmel_xdmac_dev_pm_ops'" compilation warning
> when CONFIG_PM is not defined.
> 
> Fixes: 8e0c7e486014 ("dmaengine: at_xdmac: use pm_ptr()")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  drivers/dma/at_xdmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 7fb19bd18ac3..f5d053df66a5 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -2207,7 +2207,7 @@ static int at_xdmac_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static const struct dev_pm_ops atmel_xdmac_dev_pm_ops = {
> +static const struct dev_pm_ops __maybe_unused atmel_xdmac_dev_pm_ops = {
>  	.prepare	= atmel_xdmac_prepare,
>  	SET_LATE_SYSTEM_SLEEP_PM_OPS(atmel_xdmac_suspend, atmel_xdmac_resume)
>  };
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmaengine: at_xdmac: fix compilation warning
  2021-10-25  7:40 [PATCH] dmaengine: at_xdmac: fix compilation warning Claudiu Beznea
  2021-10-25  8:34 ` Tudor.Ambarus
@ 2021-10-28 17:22 ` Vinod Koul
  2021-12-08 10:41 ` Nicolas Ferre
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-10-28 17:22 UTC (permalink / raw)
  To: Claudiu Beznea
  Cc: ludovic.desroches, tudor.ambarus, linux-arm-kernel, dmaengine,
	linux-kernel, kernel test robot

On 25-10-21, 10:40, Claudiu Beznea wrote:
> Fixed "unused variable 'atmel_xdmac_dev_pm_ops'" compilation warning
> when CONFIG_PM is not defined.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmaengine: at_xdmac: fix compilation warning
  2021-10-25  7:40 [PATCH] dmaengine: at_xdmac: fix compilation warning Claudiu Beznea
  2021-10-25  8:34 ` Tudor.Ambarus
  2021-10-28 17:22 ` Vinod Koul
@ 2021-12-08 10:41 ` Nicolas Ferre
  2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-12-08 10:41 UTC (permalink / raw)
  To: Claudiu Beznea, ludovic.desroches, tudor.ambarus, vkoul
  Cc: linux-arm-kernel, dmaengine, linux-kernel, kernel test robot

On 25/10/2021 at 09:40, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Fixed "unused variable 'atmel_xdmac_dev_pm_ops'" compilation warning
> when CONFIG_PM is not defined.
> 
> Fixes: 8e0c7e486014 ("dmaengine: at_xdmac: use pm_ptr()")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

If needed:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks, best regards,
   Nicolas

> ---
>   drivers/dma/at_xdmac.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 7fb19bd18ac3..f5d053df66a5 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -2207,7 +2207,7 @@ static int at_xdmac_remove(struct platform_device *pdev)
>          return 0;
>   }
> 
> -static const struct dev_pm_ops atmel_xdmac_dev_pm_ops = {
> +static const struct dev_pm_ops __maybe_unused atmel_xdmac_dev_pm_ops = {
>          .prepare        = atmel_xdmac_prepare,
>          SET_LATE_SYSTEM_SLEEP_PM_OPS(atmel_xdmac_suspend, atmel_xdmac_resume)
>   };
> --
> 2.33.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-08 10:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25  7:40 [PATCH] dmaengine: at_xdmac: fix compilation warning Claudiu Beznea
2021-10-25  8:34 ` Tudor.Ambarus
2021-10-28 17:22 ` Vinod Koul
2021-12-08 10:41 ` Nicolas Ferre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).