* [PATCH v1 1/2] media: dt-bindings: media: camss: sdm845: Make clock-lanes property const
@ 2021-10-25 10:33 Robert Foss
2021-10-25 10:33 ` [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property Robert Foss
0 siblings, 1 reply; 5+ messages in thread
From: Robert Foss @ 2021-10-25 10:33 UTC (permalink / raw)
To: robert.foss, todor.too, agross, bjorn.andersson, mchehab,
robh+dt, angelogioacchino.delregno, linux-media, linux-arm-msm,
devicetree, linux-kernel, Bryan O'Donoghue, Andrey Konovalov
Mistakenly only one out of four CSI ports had the clock-lane marked as
const.
Signed-off-by: Robert Foss <robert.foss@linaro.org>
---
.../devicetree/bindings/media/qcom,sdm845-camss.yaml | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index 9ca5dfa7f226..d8fb6ce1d7f9 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -106,7 +106,8 @@ properties:
properties:
clock-lanes:
- maxItems: 1
+ items:
+ - const: 7
data-lanes:
minItems: 1
@@ -153,7 +154,8 @@ properties:
properties:
clock-lanes:
- maxItems: 1
+ items:
+ - const: 7
data-lanes:
minItems: 1
@@ -176,7 +178,8 @@ properties:
properties:
clock-lanes:
- maxItems: 1
+ items:
+ - const: 7
data-lanes:
minItems: 1
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property
2021-10-25 10:33 [PATCH v1 1/2] media: dt-bindings: media: camss: sdm845: Make clock-lanes property const Robert Foss
@ 2021-10-25 10:33 ` Robert Foss
2021-11-01 20:30 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Robert Foss @ 2021-10-25 10:33 UTC (permalink / raw)
To: robert.foss, todor.too, agross, bjorn.andersson, mchehab,
robh+dt, angelogioacchino.delregno, linux-media, linux-arm-msm,
devicetree, linux-kernel, Bryan O'Donoghue, Andrey Konovalov
The clock-lanes property corresponds to a hardware register field
that is required to be set, in order to enable the CSI clock signal.
The physical lane of the clock signal is not programmable, but only
togglable On or Off, which what BIT(7) of the
CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(5) register controls.
Signed-off-by: Robert Foss <robert.foss@linaro.org>
---
.../devicetree/bindings/media/qcom,msm8996-camss.yaml | 5 +++++
.../devicetree/bindings/media/qcom,sdm660-camss.yaml | 5 +++++
.../devicetree/bindings/media/qcom,sdm845-camss.yaml | 5 +++++
3 files changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
index 38be41e932f0..d4da1fad12cf 100644
--- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
@@ -106,6 +106,11 @@ properties:
properties:
clock-lanes:
+ description:
+ The index of the clock-lane is not programmable by
+ the hardware, but is required to define a CSI port.
+ Lane 7 reflects the hardware register field that enables
+ the clock lane.
items:
- const: 7
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
index 841a1aafdd13..f110152909b9 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
@@ -112,6 +112,11 @@ properties:
properties:
clock-lanes:
+ description:
+ The index of the clock-lane is not programmable by
+ the hardware, but is required to define a CSI port.
+ Lane 7 reflects the hardware register field that enables
+ the clock lane.
items:
- const: 7
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index d8fb6ce1d7f9..087d5606f2be 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -106,6 +106,11 @@ properties:
properties:
clock-lanes:
+ description:
+ The index of the clock-lane is not programmable by
+ the hardware, but is required to define a CSI port.
+ Lane 7 reflects the hardware register field that enables
+ the clock lane.
items:
- const: 7
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property
2021-10-25 10:33 ` [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property Robert Foss
@ 2021-11-01 20:30 ` Rob Herring
2021-11-02 11:49 ` Robert Foss
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2021-11-01 20:30 UTC (permalink / raw)
To: Robert Foss
Cc: todor.too, agross, bjorn.andersson, mchehab,
angelogioacchino.delregno, linux-media, linux-arm-msm,
devicetree, linux-kernel, Bryan O'Donoghue, Andrey Konovalov
On Mon, Oct 25, 2021 at 12:33:22PM +0200, Robert Foss wrote:
> The clock-lanes property corresponds to a hardware register field
> that is required to be set, in order to enable the CSI clock signal.
>
> The physical lane of the clock signal is not programmable, but only
> togglable On or Off, which what BIT(7) of the
> CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(5) register controls.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> ---
> .../devicetree/bindings/media/qcom,msm8996-camss.yaml | 5 +++++
> .../devicetree/bindings/media/qcom,sdm660-camss.yaml | 5 +++++
> .../devicetree/bindings/media/qcom,sdm845-camss.yaml | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> index 38be41e932f0..d4da1fad12cf 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> @@ -106,6 +106,11 @@ properties:
>
> properties:
> clock-lanes:
> + description:
> + The index of the clock-lane is not programmable by
> + the hardware, but is required to define a CSI port.
> + Lane 7 reflects the hardware register field that enables
> + the clock lane.
If it is fixed, then it should not be required. Fix the required part.
> items:
> - const: 7
I don't know how we let that in, but this should be the lane number.
Each binding can't be making up its own interpretation.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property
2021-11-01 20:30 ` Rob Herring
@ 2021-11-02 11:49 ` Robert Foss
2021-11-02 14:18 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Robert Foss @ 2021-11-02 11:49 UTC (permalink / raw)
To: Rob Herring
Cc: todor.too, agross, bjorn.andersson, mchehab,
angelogioacchino.delregno, linux-media, linux-arm-msm,
devicetree, linux-kernel, Bryan O'Donoghue, Andrey Konovalov
On Mon, 1 Nov 2021 at 21:30, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Oct 25, 2021 at 12:33:22PM +0200, Robert Foss wrote:
> > The clock-lanes property corresponds to a hardware register field
> > that is required to be set, in order to enable the CSI clock signal.
> >
> > The physical lane of the clock signal is not programmable, but only
> > togglable On or Off, which what BIT(7) of the
> > CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(5) register controls.
> >
> > Signed-off-by: Robert Foss <robert.foss@linaro.org>
> > ---
> > .../devicetree/bindings/media/qcom,msm8996-camss.yaml | 5 +++++
> > .../devicetree/bindings/media/qcom,sdm660-camss.yaml | 5 +++++
> > .../devicetree/bindings/media/qcom,sdm845-camss.yaml | 5 +++++
> > 3 files changed, 15 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > index 38be41e932f0..d4da1fad12cf 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > @@ -106,6 +106,11 @@ properties:
> >
> > properties:
> > clock-lanes:
> > + description:
> > + The index of the clock-lane is not programmable by
> > + the hardware, but is required to define a CSI port.
> > + Lane 7 reflects the hardware register field that enables
> > + the clock lane.
>
> If it is fixed, then it should not be required. Fix the required part.
>
> > items:
> > - const: 7
>
> I don't know how we let that in, but this should be the lane number.
> Each binding can't be making up its own interpretation.
If the clock lane number isn't programmable, can clock-lanes be omitted?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property
2021-11-02 11:49 ` Robert Foss
@ 2021-11-02 14:18 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-11-02 14:18 UTC (permalink / raw)
To: Robert Foss
Cc: Todor Tomov, Gross, Andy, Bjorn Andersson, Mauro Carvalho Chehab,
AngeloGioacchino Del Regno, Linux Media Mailing List,
linux-arm-msm, devicetree, linux-kernel, Bryan O'Donoghue,
Andrey Konovalov
On Tue, Nov 2, 2021 at 6:49 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Mon, 1 Nov 2021 at 21:30, Rob Herring <robh@kernel.org> wrote:
> >
> > On Mon, Oct 25, 2021 at 12:33:22PM +0200, Robert Foss wrote:
> > > The clock-lanes property corresponds to a hardware register field
> > > that is required to be set, in order to enable the CSI clock signal.
> > >
> > > The physical lane of the clock signal is not programmable, but only
> > > togglable On or Off, which what BIT(7) of the
> > > CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(5) register controls.
> > >
> > > Signed-off-by: Robert Foss <robert.foss@linaro.org>
> > > ---
> > > .../devicetree/bindings/media/qcom,msm8996-camss.yaml | 5 +++++
> > > .../devicetree/bindings/media/qcom,sdm660-camss.yaml | 5 +++++
> > > .../devicetree/bindings/media/qcom,sdm845-camss.yaml | 5 +++++
> > > 3 files changed, 15 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > > index 38be41e932f0..d4da1fad12cf 100644
> > > --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > > +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> > > @@ -106,6 +106,11 @@ properties:
> > >
> > > properties:
> > > clock-lanes:
> > > + description:
> > > + The index of the clock-lane is not programmable by
> > > + the hardware, but is required to define a CSI port.
> > > + Lane 7 reflects the hardware register field that enables
> > > + the clock lane.
> >
> > If it is fixed, then it should not be required. Fix the required part.
> >
> > > items:
> > > - const: 7
> >
> > I don't know how we let that in, but this should be the lane number.
> > Each binding can't be making up its own interpretation.
>
> If the clock lane number isn't programmable, can clock-lanes be omitted?
Yes, that would be the correct thing to do.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-02 14:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 10:33 [PATCH v1 1/2] media: dt-bindings: media: camss: sdm845: Make clock-lanes property const Robert Foss
2021-10-25 10:33 ` [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property Robert Foss
2021-11-01 20:30 ` Rob Herring
2021-11-02 11:49 ` Robert Foss
2021-11-02 14:18 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).