* [PATCH] Input: iforce - fix control-message timeout
@ 2021-10-25 11:55 Johan Hovold
2021-11-10 6:58 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2021-10-25 11:55 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input, linux-usb, linux-kernel, Johan Hovold, stable
USB control-message timeouts are specified in milliseconds and should
specifically not vary with CONFIG_HZ.
Fixes: 487358627825 ("Input: iforce - use DMA-safe buffer when getting IDs from USB")
Cc: stable@vger.kernel.org # 5.3
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/input/joystick/iforce/iforce-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c
index 6c554c11a7ac..ea58805c480f 100644
--- a/drivers/input/joystick/iforce/iforce-usb.c
+++ b/drivers/input/joystick/iforce/iforce-usb.c
@@ -92,7 +92,7 @@ static int iforce_usb_get_id(struct iforce *iforce, u8 id,
id,
USB_TYPE_VENDOR | USB_DIR_IN |
USB_RECIP_INTERFACE,
- 0, 0, buf, IFORCE_MAX_LENGTH, HZ);
+ 0, 0, buf, IFORCE_MAX_LENGTH, 1000);
if (status < 0) {
dev_err(&iforce_usb->intf->dev,
"usb_submit_urb failed: %d\n", status);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: iforce - fix control-message timeout
2021-10-25 11:55 [PATCH] Input: iforce - fix control-message timeout Johan Hovold
@ 2021-11-10 6:58 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2021-11-10 6:58 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-input, linux-usb, linux-kernel, stable
On Mon, Oct 25, 2021 at 01:55:01PM +0200, Johan Hovold wrote:
> USB control-message timeouts are specified in milliseconds and should
> specifically not vary with CONFIG_HZ.
>
> Fixes: 487358627825 ("Input: iforce - use DMA-safe buffer when getting IDs from USB")
> Cc: stable@vger.kernel.org # 5.3
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-10 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 11:55 [PATCH] Input: iforce - fix control-message timeout Johan Hovold
2021-11-10 6:58 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).