From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sboyd@kernel.org, mturquette@baylibre.com, abel.vesa@nxp.com,
s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2] clk: imx: gate off peripheral clock slice
Date: Mon, 25 Oct 2021 20:29:02 +0800 [thread overview]
Message-ID: <20211025122902.1151-1-peng.fan@oss.nxp.com> (raw)
From: Peng Fan <peng.fan@nxp.com>
The Peripheral clocks are default enabled when SoC power on, and
bootloader not gate off the clocks when booting Linux Kernel.
So Linux Kernel is not aware the peripheral clocks are enabled and
still take them as disabled because of enable count is zero.
Then Peripheral clock's source without clock gated off could be
changed when have assigned-parents in device tree
However, per i.MX8M* reference mannual, "Peripheral clock slices must
be stopped to change the clock source", so need to gate off the
the peripheral clock when registering the clocks to avoid glitch.
Tested boot on i.MX8MM/P-EVK board
Fixes: d3ff9728134e ("clk: imx: Add imx composite clock")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
Add Fixes tag
drivers/clk/imx/clk-composite-8m.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c
index 2dfd6149e528..ee41fbf90589 100644
--- a/drivers/clk/imx/clk-composite-8m.c
+++ b/drivers/clk/imx/clk-composite-8m.c
@@ -184,6 +184,7 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name,
struct clk_mux *mux = NULL;
const struct clk_ops *divider_ops;
const struct clk_ops *mux_ops;
+ u32 val;
mux = kzalloc(sizeof(*mux), GFP_KERNEL);
if (!mux)
@@ -216,8 +217,14 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name,
div->width = PCG_PREDIV_WIDTH;
divider_ops = &imx8m_clk_composite_divider_ops;
mux_ops = &clk_mux_ops;
- if (!(composite_flags & IMX_COMPOSITE_FW_MANAGED))
+ if (!(composite_flags & IMX_COMPOSITE_FW_MANAGED)) {
flags |= CLK_SET_PARENT_GATE;
+ if (!(flags & CLK_IS_CRITICAL)) {
+ val = readl(reg);
+ val &= ~BIT(PCG_CGC_SHIFT);
+ writel(val, reg);
+ }
+ }
}
div->lock = &imx_ccm_lock;
--
2.30.0
next reply other threads:[~2021-10-25 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:29 Peng Fan (OSS) [this message]
2021-10-25 11:54 ` [PATCH V2] clk: imx: gate off peripheral clock slice Ahmad Fatoum
2021-10-25 11:59 ` Ahmad Fatoum
2021-10-25 12:08 ` Abel Vesa
2021-10-29 16:47 ` Ahmad Fatoum
2021-11-01 2:26 ` Peng Fan
2021-11-02 7:45 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025122902.1151-1-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).