From: Peng Fan <peng.fan@nxp.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Abel Vesa <abel.vesa@nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "sboyd@kernel.org" <sboyd@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V2] clk: imx: gate off peripheral clock slice
Date: Tue, 2 Nov 2021 07:45:50 +0000 [thread overview]
Message-ID: <DU2PR04MB90209DF8A713D81E4200B171888B9@DU2PR04MB9020.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <d3fd4bdf-6e3d-7752-dcc2-293fc5e6f469@pengutronix.de>
> Subject: Re: [PATCH V2] clk: imx: gate off peripheral clock slice
>
> Hello Peng, Abel,
>
> On 25.10.21 14:08, Abel Vesa wrote:
> > On 21-10-25 20:29:02, Peng Fan (OSS) wrote:
> >> From: Peng Fan <peng.fan@nxp.com>
> >>
> >> The Peripheral clocks are default enabled when SoC power on, and
> >> bootloader not gate off the clocks when booting Linux Kernel.
> >>
> >> So Linux Kernel is not aware the peripheral clocks are enabled and
> >> still take them as disabled because of enable count is zero.
> >>
> >> Then Peripheral clock's source without clock gated off could be
> >> changed when have assigned-parents in device tree
> >>
> >> However, per i.MX8M* reference mannual, "Peripheral clock slices must
> >> be stopped to change the clock source", so need to gate off the the
> >> peripheral clock when registering the clocks to avoid glitch.
> >>
> >> Tested boot on i.MX8MM/P-EVK board
>
> I just noticed this breaks earlycon on an i.MX8MN, I assume because the
> earlycon driver will access unclocked registers.
>
> On the i.MX8MN, I also noticed that disabling usb_phy_ref hangs the system,
> whether via sysfs or via this patch. Still trying to figure that one out.
This patch indeed breaks earlycon, need to think out how to fix this.
But I am still not sure why usb_phy_ref matters here.
Thanks,
Peng.
>
> Cheers,
> Ahmad
>
> >> Fixes: d3ff9728134e ("clk: imx: Add imx composite clock")
> >> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >> ---
> >>
> >> V2:
> >> Add Fixes tag
> >>
> >> drivers/clk/imx/clk-composite-8m.c | 9 ++++++++-
> >> 1 file changed, 8 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/clk/imx/clk-composite-8m.c
> >> b/drivers/clk/imx/clk-composite-8m.c
> >> index 2dfd6149e528..ee41fbf90589 100644
> >> --- a/drivers/clk/imx/clk-composite-8m.c
> >> +++ b/drivers/clk/imx/clk-composite-8m.c
> >> @@ -184,6 +184,7 @@ struct clk_hw *__imx8m_clk_hw_composite(const
> char *name,
> >> struct clk_mux *mux = NULL;
> >> const struct clk_ops *divider_ops;
> >> const struct clk_ops *mux_ops;
> >> + u32 val;
> >>
> >> mux = kzalloc(sizeof(*mux), GFP_KERNEL);
> >> if (!mux)
> >> @@ -216,8 +217,14 @@ struct clk_hw
> *__imx8m_clk_hw_composite(const char *name,
> >> div->width = PCG_PREDIV_WIDTH;
> >> divider_ops = &imx8m_clk_composite_divider_ops;
> >> mux_ops = &clk_mux_ops;
> >> - if (!(composite_flags & IMX_COMPOSITE_FW_MANAGED))
> >> + if (!(composite_flags & IMX_COMPOSITE_FW_MANAGED)) {
> >> flags |= CLK_SET_PARENT_GATE;
> >> + if (!(flags & CLK_IS_CRITICAL)) {
> >> + val = readl(reg);
> >> + val &= ~BIT(PCG_CGC_SHIFT);
> >> + writel(val, reg);
> >> + }
> >> + }
> >
> > Though I'm usually against special cases like this one. I think the
> > clock core needs some generic flag that would read the state from HW
> > on probe and/or another generic flag for disabling on probe.
> >
> > But for now, I'm OK with this:
> >
> > Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> >
> >> }
> >>
> >> div->lock = &imx_ccm_lock;
> >> --
> >> 2.30.0
> >>
> >
> >
>
>
> --
> Pengutronix e.K. |
> |
> Steuerwalder Str. 21 |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> engutronix.de%2F&data=04%7C01%7Cpeng.fan%40nxp.com%7C626714
> cd2773448a4c0608d99afbc80d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C637711228448591454%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C10
> 00&sdata=235%2BBGnDLUAIorqGKVVt%2BUKlSAf5jT68wq2s5FMDolY%
> 3D&reserved=0 |
> 31137 Hildesheim, Germany | Phone:
> +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |
prev parent reply other threads:[~2021-11-02 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:29 [PATCH V2] clk: imx: gate off peripheral clock slice Peng Fan (OSS)
2021-10-25 11:54 ` Ahmad Fatoum
2021-10-25 11:59 ` Ahmad Fatoum
2021-10-25 12:08 ` Abel Vesa
2021-10-29 16:47 ` Ahmad Fatoum
2021-11-01 2:26 ` Peng Fan
2021-11-02 7:45 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU2PR04MB90209DF8A713D81E4200B171888B9@DU2PR04MB9020.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=a.fatoum@pengutronix.de \
--cc=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).