* [PATCH] mm: list_lru: remove holding lru lock
@ 2021-10-25 12:45 Muchun Song
0 siblings, 0 replies; only message in thread
From: Muchun Song @ 2021-10-25 12:45 UTC (permalink / raw)
To: akpm, mhocko, shakeelb, willy; +Cc: linux-mm, linux-kernel, Muchun Song
Since commit e5bc3af7734f ("rcu: Consolidate PREEMPT and !PREEMPT
synchronize_rcu()"), the critical section of spin lock can serve
as an RCU read-side critical section which already allows readers
that hold nlru->lock avoid taking rcu lock. So just to remove
holding lock.
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
mm/list_lru.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/mm/list_lru.c b/mm/list_lru.c
index 2bba1cd68bb3..7572f8e70b86 100644
--- a/mm/list_lru.c
+++ b/mm/list_lru.c
@@ -401,18 +401,7 @@ static int memcg_update_list_lru_node(struct list_lru_node *nlru,
}
memcpy(&new->lru, &old->lru, flex_array_size(new, lru, old_size));
-
- /*
- * The locking below allows readers that hold nlru->lock avoid taking
- * rcu_read_lock (see list_lru_from_memcg_idx).
- *
- * Since list_lru_{add,del} may be called under an IRQ-safe lock,
- * we have to use IRQ-safe primitives here to avoid deadlock.
- */
- spin_lock_irq(&nlru->lock);
rcu_assign_pointer(nlru->memcg_lrus, new);
- spin_unlock_irq(&nlru->lock);
-
kvfree_rcu(old, rcu);
return 0;
}
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-25 12:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 12:45 [PATCH] mm: list_lru: remove holding lru lock Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).