* [PATCH -next] virtio-pci: fix error return code in vp_legacy_probe()
@ 2021-10-26 13:47 Yang Yingliang
2021-10-27 2:37 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-10-26 13:47 UTC (permalink / raw)
To: linux-kernel, virtualization; +Cc: jasowang, mst
Return error code if pci_iomap() fails in vp_legacy_probe()
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: c3ca8a3eeb54 ("virtio-pci: introduce legacy device module")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/virtio/virtio_pci_legacy_dev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci_legacy_dev.c b/drivers/virtio/virtio_pci_legacy_dev.c
index 9b97680dd02b..4ca3ef38d3bf 100644
--- a/drivers/virtio/virtio_pci_legacy_dev.c
+++ b/drivers/virtio/virtio_pci_legacy_dev.c
@@ -45,8 +45,10 @@ int vp_legacy_probe(struct virtio_pci_legacy_device *ldev)
return rc;
ldev->ioaddr = pci_iomap(pci_dev, 0, 0);
- if (!ldev->ioaddr)
+ if (!ldev->ioaddr) {
+ rc = -ENOMEM;
goto err_iomap;
+ }
ldev->isr = ldev->ioaddr + VIRTIO_PCI_ISR;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] virtio-pci: fix error return code in vp_legacy_probe()
2021-10-26 13:47 [PATCH -next] virtio-pci: fix error return code in vp_legacy_probe() Yang Yingliang
@ 2021-10-27 2:37 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2021-10-27 2:37 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, virtualization, mst
On Tue, Oct 26, 2021 at 9:39 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> Return error code if pci_iomap() fails in vp_legacy_probe()
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: c3ca8a3eeb54 ("virtio-pci: introduce legacy device module")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Acked-by: Jason Wang <jasowang@redhat.com>
> drivers/virtio/virtio_pci_legacy_dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_pci_legacy_dev.c b/drivers/virtio/virtio_pci_legacy_dev.c
> index 9b97680dd02b..4ca3ef38d3bf 100644
> --- a/drivers/virtio/virtio_pci_legacy_dev.c
> +++ b/drivers/virtio/virtio_pci_legacy_dev.c
> @@ -45,8 +45,10 @@ int vp_legacy_probe(struct virtio_pci_legacy_device *ldev)
> return rc;
>
> ldev->ioaddr = pci_iomap(pci_dev, 0, 0);
> - if (!ldev->ioaddr)
> + if (!ldev->ioaddr) {
> + rc = -ENOMEM;
> goto err_iomap;
> + }
>
> ldev->isr = ldev->ioaddr + VIRTIO_PCI_ISR;
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-27 2:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 13:47 [PATCH -next] virtio-pci: fix error return code in vp_legacy_probe() Yang Yingliang
2021-10-27 2:37 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).