* [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description
@ 2021-10-27 10:21 Anssi Hannula
2021-10-28 8:45 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Anssi Hannula @ 2021-10-27 10:21 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby; +Cc: linux-kernel, linux-serial
TTY_DRIVER_REAL_RAW flag (which is always set for e.g. serial ports)
documentation says that driver must always set special character
handling flags in certain conditions.
However, as the following sentence makes clear, what is actually
intended is the opposite.
Fix that by removing the unintended double negation.
Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
---
This one seems to have been there since 1994.
include/linux/tty_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
index c20431d8def8..5bec04481c60 100644
--- a/include/linux/tty_driver.h
+++ b/include/linux/tty_driver.h
@@ -360,7 +360,7 @@ static inline void tty_set_operations(struct tty_driver *driver,
* Used for PTY's, in particular.
*
* TTY_DRIVER_REAL_RAW --- if set, indicates that the driver will
- * guarantee never not to set any special character handling
+ * guarantee never to set any special character handling
* flags if ((IGNBRK || (!BRKINT && !PARMRK)) && (IGNPAR ||
* !INPCK)). That is, if there is no reason for the driver to
* send notifications of parity and break characters up to the
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description
2021-10-27 10:21 [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description Anssi Hannula
@ 2021-10-28 8:45 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2021-10-28 8:45 UTC (permalink / raw)
To: Anssi Hannula; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, linux-serial
On Wed, Oct 27, 2021 at 01:21:24PM +0300, Anssi Hannula wrote:
> TTY_DRIVER_REAL_RAW flag (which is always set for e.g. serial ports)
> documentation says that driver must always set special character
> handling flags in certain conditions.
>
> However, as the following sentence makes clear, what is actually
> intended is the opposite.
>
> Fix that by removing the unintended double negation.
>
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
> ---
Acked-by: Johan Hovold <johan@kernel.org>
> This one seems to have been there since 1994.
>
> include/linux/tty_driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
> index c20431d8def8..5bec04481c60 100644
> --- a/include/linux/tty_driver.h
> +++ b/include/linux/tty_driver.h
> @@ -360,7 +360,7 @@ static inline void tty_set_operations(struct tty_driver *driver,
> * Used for PTY's, in particular.
> *
> * TTY_DRIVER_REAL_RAW --- if set, indicates that the driver will
> - * guarantee never not to set any special character handling
> + * guarantee never to set any special character handling
> * flags if ((IGNBRK || (!BRKINT && !PARMRK)) && (IGNPAR ||
> * !INPCK)). That is, if there is no reason for the driver to
> * send notifications of parity and break characters up to the
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-28 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 10:21 [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description Anssi Hannula
2021-10-28 8:45 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).