* [PATCH v2] checkpatch: Improve CVS revision marker check
@ 2021-10-27 10:56 Kari Argillander
0 siblings, 0 replies; only message in thread
From: Kari Argillander @ 2021-10-27 10:56 UTC (permalink / raw)
To: apw, joe
Cc: Kari Argillander, dwaipayanray1, lukas.bulwahn, linux-kernel, ntfs3
This check gives false alarms at least in fs/ntfs3/ as there $LogFile is
used quite lot because it is name of file which logs NTFS metadata. This
improves check so it does not false alarm so easily.
Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
---
v2:
- Just improve checking. Thank for Jow Perches for regex.
v1:
Link: lore.kernel.org/ntfs3/20211026231637.3750-1-kari.argillander@gmail.com
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 461d4221e4a4..a45c6274fcb4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4018,7 +4018,7 @@ sub process {
}
# check for RCS/CVS revision markers
- if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
+ if ($rawline =~ /^\+.*\$(?:Revision|Log|Id)(?::.*)?\$/) {
WARN("CVS_KEYWORD",
"CVS style keyword markers, these will _not_ be updated\n". $herecurr);
}
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-10-27 10:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 10:56 [PATCH v2] checkpatch: Improve CVS revision marker check Kari Argillander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).