From: Serge Semin <fancer.lancer@gmail.com>
To: Brad Larson <brad@pensando.io>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Rob Herring <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
broonie@kernel.org, adrian.hunter@intel.com,
ulf.hansson@linaro.org, olof@lixom.net,
linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/11] spi: dw: Add Pensando Elba SoC SPI Controller bindings
Date: Thu, 28 Oct 2021 10:52:31 +0300 [thread overview]
Message-ID: <20211028075231.47ihqwopu5qodhl7@mobilestation> (raw)
In-Reply-To: <20211028074945.rv2j5kgzk7yc2srr@mobilestation>
On Thu, Oct 28, 2021 at 10:49:48AM +0300, Serge Semin wrote:
> On Sun, Oct 24, 2021 at 06:51:50PM -0700, Brad Larson wrote:
> > The Pensando Elba SoC has integrated the DW APB SPI Controller
>
> Please add the "dt-bindings: " prefix to the patch name and discard
> the word "bindings" from the title as the submitting DT-patches
> requires:
> Documentation/devicetree/bindings/submitting-patches.rst
>
> >
> > Signed-off-by: Brad Larson <brad@pensando.io>
> > ---
> > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > index d7e08b03e204..0b5ebb2ae6e7 100644
> > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> > @@ -73,6 +73,8 @@ properties:
> > - renesas,r9a06g032-spi # RZ/N1D
> > - renesas,r9a06g033-spi # RZ/N1S
> > - const: renesas,rzn1-spi # RZ/N1
>
> > + - description: Pensando Elba SoC SPI Controller
> > + const: pensando,elba-spi
>
> AFAICS from the driver-part of the patchset it's not enough. You've
> also got the syscon phandle, which needs to be reflected in the
> bindings. That also makes me thinking that you didn't perform the
> "dtbs_check" on the dts-files you were going to submit,
> but for some reason discarded from this series (btw why?).
Oops. Found it. The question regarding "dtbs_check" is still actual.
-Sergey
> If you did you would
> have got an error of an unevaluated property detection.
>
> -Sergey
>
> >
> > reg:
> > minItems: 1
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2021-10-28 7:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 1:51 [PATCH v3 00/11] Support Pensando Elba SoC Brad Larson
2021-10-25 1:51 ` [PATCH v3 01/11] dt-bindings: arm: pensando: add Pensando boards Brad Larson
2021-10-27 21:37 ` Rob Herring
2021-10-25 1:51 ` [PATCH v3 02/11] dt-bindings: Add vendor prefix for Pensando Systems Brad Larson
2021-10-27 21:38 ` Rob Herring
2021-11-05 0:16 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding Brad Larson
2021-10-25 12:54 ` Rob Herring
2021-11-05 0:13 ` Brad Larson
2021-10-26 18:10 ` Rob Herring
2021-11-17 1:21 ` Brad Larson
2021-11-17 1:27 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Brad Larson
2021-10-27 21:38 ` Rob Herring
2021-10-28 7:26 ` Serge Semin
2021-11-15 22:05 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 05/11] spi: dw: Add Pensando Elba SoC SPI Controller bindings Brad Larson
2021-10-27 21:42 ` Rob Herring
2021-10-28 7:49 ` Serge Semin
2021-10-28 7:52 ` Serge Semin [this message]
2021-11-15 22:24 ` Brad Larson
2021-11-16 11:29 ` Serge Semin
2021-11-16 23:11 ` Brad Larson
2021-11-17 8:19 ` Serge Semin
2021-11-17 21:35 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 06/11] MAINTAINERS: Add entry for PENSANDO Brad Larson
2021-10-25 1:51 ` [PATCH v3 07/11] arm64: Add config for Pensando SoC platforms Brad Larson
2021-10-25 1:51 ` [PATCH v3 08/11] spi: cadence-quadspi: Add compatible for Pensando Elba SoC Brad Larson
2021-10-25 1:51 ` [PATCH v3 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson
2021-10-25 1:51 ` [PATCH v3 10/11] spi: dw: Add support for Pensando Elba SoC Brad Larson
2021-10-28 9:11 ` Serge Semin
2021-10-31 13:19 ` Andy Shevchenko
2021-10-25 1:51 ` [PATCH v3 11/11] arm64: dts: Add Pensando Elba SoC support Brad Larson
2021-10-25 9:17 ` Mark Rutland
2021-10-25 11:15 ` Marc Zyngier
2021-11-05 0:02 ` Brad Larson
2021-11-05 11:35 ` Marc Zyngier
2021-11-08 19:35 ` Brad Larson
2021-11-08 19:53 ` Marc Zyngier
2021-11-08 20:01 ` Brad Larson
2021-11-04 22:53 ` Brad Larson
2021-11-08 10:25 ` Mark Rutland
2021-11-08 19:02 ` Brad Larson
2021-10-27 21:37 ` Rob Herring
2021-11-11 2:08 ` Brad Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028075231.47ihqwopu5qodhl7@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=brad@pensando.io \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).