From: Brad Larson <brad@pensando.io>
To: Rob Herring <robh@kernel.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Mark Brown <broonie@kernel.org>,
Serge Semin <fancer.lancer@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Olof Johansson <olof@lixom.net>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding
Date: Tue, 16 Nov 2021 17:21:41 -0800 [thread overview]
Message-ID: <CAK9rFnyk=gW_ZRZUci3byu=DNwdrmKBb30HQgxK0iWJuVVPbfQ@mail.gmail.com> (raw)
In-Reply-To: <YXhErvvSfKIBvHae@robh.at.kernel.org>
Hi Rob,
On Tue, Oct 26, 2021 at 11:10 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, Oct 24, 2021 at 06:51:48PM -0700, Brad Larson wrote:
> > Pensando Elba ARM 64-bit SoC is integrated with this IP and
> > explicitly controls byte-lane enables resulting in an additional
> > reg property resource.
> >
> > Signed-off-by: Brad Larson <brad@pensando.io>
> > ---
> > .../devicetree/bindings/mmc/cdns,sdhci.yaml | 13 ++++++++-----
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> > index af7442f73881..6c68b7b5abec 100644
> > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> > @@ -15,13 +15,16 @@ allOf:
> >
> > properties:
> > compatible:
> > - items:
> > - - enum:
> > - - socionext,uniphier-sd4hc
> > - - const: cdns,sd4hc
> > + oneOf:
> > + - items:
> > + - enum:
> > + - socionext,uniphier-sd4hc
> > + - pensando,elba-emmc
> > + - const: cdns,sd4hc
> >
> > reg:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
>
> If there is more than 1, then you need to describe what each entry is.
The dtschema update and yamllint install shows the errors your bot
reported. With the updated cdns,sdhci.yaml to add the description for
Elba's two reg items this is what I'm getting with in 5.16.0-rc1
(next-20211116):
diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
index 4207fed62dfe..c01a7283c468 100644
--- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
@@ -12,17 +12,44 @@ maintainers:
allOf:
- $ref: mmc-controller.yaml
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - socionext,uniphier-sd4hc
+ then:
+ properties:
+ reg:
+ maxItems: 1
+ items:
+ - description: SDHCI CDNS HRS registers
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - pensando,elba-emmc
+ then:
+ properties:
+ reg:
+ maxItems: 2
+ items:
+ - description: SDHCI CDNS HRS registers
+ - description: Byte lane control register
properties:
compatible:
- items:
- - enum:
- - microchip,mpfs-sd4hc
- - socionext,uniphier-sd4hc
- - const: cdns,sd4hc
+ oneOf:
+ - items:
+ - enum:
+ - socionext,uniphier-sd4hc
+ - pensando,elba-emmc
+ - const: cdns,sd4hc
reg:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
interrupts:
maxItems: 1
$ make DT_CHECKER_FLAGS=-m dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema-examples.json
SCHEMA Documentation/devicetree/bindings/processed-schema-examples.json
...
DTEX Documentation/devicetree/bindings/mmc/cdns,sdhci.example.dts
DTC Documentation/devicetree/bindings/mmc/cdns,sdhci.example.dt.yaml
CHECK Documentation/devicetree/bindings/mmc/cdns,sdhci.example.dt.yaml
These errors are reported for unrelated files not on DT_SCHEMA_FILES
bindings/net/qcom,ipa.yaml: ignoring, error in schema: properties:
qcom,smem-state-names
bindings/iio/adc/st,stm32-dfsdm-adc.yaml: ignoring, error in schema:
patternProperties: ^filter@[0-9]+$: properties: st,adc-channel-names
bindings/interconnect/qcom,rpmh.yaml: ignoring, error in schema:
properties: qcom,bcm-voter-names
Thanks,
Brad
next prev parent reply other threads:[~2021-11-17 1:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 1:51 [PATCH v3 00/11] Support Pensando Elba SoC Brad Larson
2021-10-25 1:51 ` [PATCH v3 01/11] dt-bindings: arm: pensando: add Pensando boards Brad Larson
2021-10-27 21:37 ` Rob Herring
2021-10-25 1:51 ` [PATCH v3 02/11] dt-bindings: Add vendor prefix for Pensando Systems Brad Larson
2021-10-27 21:38 ` Rob Herring
2021-11-05 0:16 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding Brad Larson
2021-10-25 12:54 ` Rob Herring
2021-11-05 0:13 ` Brad Larson
2021-10-26 18:10 ` Rob Herring
2021-11-17 1:21 ` Brad Larson [this message]
2021-11-17 1:27 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Brad Larson
2021-10-27 21:38 ` Rob Herring
2021-10-28 7:26 ` Serge Semin
2021-11-15 22:05 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 05/11] spi: dw: Add Pensando Elba SoC SPI Controller bindings Brad Larson
2021-10-27 21:42 ` Rob Herring
2021-10-28 7:49 ` Serge Semin
2021-10-28 7:52 ` Serge Semin
2021-11-15 22:24 ` Brad Larson
2021-11-16 11:29 ` Serge Semin
2021-11-16 23:11 ` Brad Larson
2021-11-17 8:19 ` Serge Semin
2021-11-17 21:35 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 06/11] MAINTAINERS: Add entry for PENSANDO Brad Larson
2021-10-25 1:51 ` [PATCH v3 07/11] arm64: Add config for Pensando SoC platforms Brad Larson
2021-10-25 1:51 ` [PATCH v3 08/11] spi: cadence-quadspi: Add compatible for Pensando Elba SoC Brad Larson
2021-10-25 1:51 ` [PATCH v3 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson
2021-10-25 1:51 ` [PATCH v3 10/11] spi: dw: Add support for Pensando Elba SoC Brad Larson
2021-10-28 9:11 ` Serge Semin
2021-10-31 13:19 ` Andy Shevchenko
2021-10-25 1:51 ` [PATCH v3 11/11] arm64: dts: Add Pensando Elba SoC support Brad Larson
2021-10-25 9:17 ` Mark Rutland
2021-10-25 11:15 ` Marc Zyngier
2021-11-05 0:02 ` Brad Larson
2021-11-05 11:35 ` Marc Zyngier
2021-11-08 19:35 ` Brad Larson
2021-11-08 19:53 ` Marc Zyngier
2021-11-08 20:01 ` Brad Larson
2021-11-04 22:53 ` Brad Larson
2021-11-08 10:25 ` Mark Rutland
2021-11-08 19:02 ` Brad Larson
2021-10-27 21:37 ` Rob Herring
2021-11-11 2:08 ` Brad Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK9rFnyk=gW_ZRZUci3byu=DNwdrmKBb30HQgxK0iWJuVVPbfQ@mail.gmail.com' \
--to=brad@pensando.io \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).