* [PATCH v2 0/2] mfd: atmel-flexcom: add a fix and code cosmetics @ 2021-10-28 13:51 Claudiu Beznea 2021-10-28 13:51 ` [PATCH v2 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP Claudiu Beznea 2021-10-28 13:51 ` [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Claudiu Beznea 0 siblings, 2 replies; 6+ messages in thread From: Claudiu Beznea @ 2021-10-28 13:51 UTC (permalink / raw) To: lee.jones, nicolas.ferre, alexandre.belloni, ludovic.desroches, romain.izard.pro Cc: linux-arm-kernel, linux-kernel, Claudiu Beznea The patches in this series: 1/2 - use __maybe_unused around PM code 2/2 - fixes the PM Changes in v2: - collected tags Claudiu Beznea (2): mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP mfd: atmel-flexcom: use resume_noirq drivers/mfd/atmel-flexcom.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) -- 2.33.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP 2021-10-28 13:51 [PATCH v2 0/2] mfd: atmel-flexcom: add a fix and code cosmetics Claudiu Beznea @ 2021-10-28 13:51 ` Claudiu Beznea 2021-11-24 15:35 ` Lee Jones 2021-10-28 13:51 ` [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Claudiu Beznea 1 sibling, 1 reply; 6+ messages in thread From: Claudiu Beznea @ 2021-10-28 13:51 UTC (permalink / raw) To: lee.jones, nicolas.ferre, alexandre.belloni, ludovic.desroches, romain.izard.pro Cc: linux-arm-kernel, linux-kernel, Claudiu Beznea Remove compilation flag and use __maybe_unused and pm_ptr instead. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> --- drivers/mfd/atmel-flexcom.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c index d2f5c073fdf3..962f66dc8813 100644 --- a/drivers/mfd/atmel-flexcom.c +++ b/drivers/mfd/atmel-flexcom.c @@ -87,8 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = { }; MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match); -#ifdef CONFIG_PM_SLEEP -static int atmel_flexcom_resume(struct device *dev) +static int __maybe_unused atmel_flexcom_resume(struct device *dev) { struct atmel_flexcom *ddata = dev_get_drvdata(dev); int err; @@ -105,7 +104,6 @@ static int atmel_flexcom_resume(struct device *dev) return 0; } -#endif static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL, atmel_flexcom_resume); @@ -114,7 +112,7 @@ static struct platform_driver atmel_flexcom_driver = { .probe = atmel_flexcom_probe, .driver = { .name = "atmel_flexcom", - .pm = &atmel_flexcom_pm_ops, + .pm = pm_ptr(&atmel_flexcom_pm_ops), .of_match_table = atmel_flexcom_of_match, }, }; -- 2.33.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP 2021-10-28 13:51 ` [PATCH v2 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP Claudiu Beznea @ 2021-11-24 15:35 ` Lee Jones 0 siblings, 0 replies; 6+ messages in thread From: Lee Jones @ 2021-11-24 15:35 UTC (permalink / raw) To: Claudiu Beznea Cc: nicolas.ferre, alexandre.belloni, ludovic.desroches, romain.izard.pro, linux-arm-kernel, linux-kernel On Thu, 28 Oct 2021, Claudiu Beznea wrote: > Remove compilation flag and use __maybe_unused and pm_ptr instead. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/mfd/atmel-flexcom.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq 2021-10-28 13:51 [PATCH v2 0/2] mfd: atmel-flexcom: add a fix and code cosmetics Claudiu Beznea 2021-10-28 13:51 ` [PATCH v2 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP Claudiu Beznea @ 2021-10-28 13:51 ` Claudiu Beznea 2021-11-24 15:36 ` Lee Jones 2022-01-10 15:38 ` Lee Jones 1 sibling, 2 replies; 6+ messages in thread From: Claudiu Beznea @ 2021-10-28 13:51 UTC (permalink / raw) To: lee.jones, nicolas.ferre, alexandre.belloni, ludovic.desroches, romain.izard.pro Cc: linux-arm-kernel, linux-kernel, Claudiu Beznea, Codrin Ciubotariu Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might be connected critical devices (like PMIC) which on suspend/resume should be suspended/resumed at the end/beginning. i2c uses .suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom to use .resume_noirq as it should be resumed before the embedded IPs. Otherwise the embedded devices might behave badly. Fixes: 7fdec11015c3 ("atmel_flexcom: Support resuming after a chip reset") Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> Tested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> --- drivers/mfd/atmel-flexcom.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c index 962f66dc8813..559eb4d352b6 100644 --- a/drivers/mfd/atmel-flexcom.c +++ b/drivers/mfd/atmel-flexcom.c @@ -87,7 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = { }; MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match); -static int __maybe_unused atmel_flexcom_resume(struct device *dev) +static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev) { struct atmel_flexcom *ddata = dev_get_drvdata(dev); int err; @@ -105,8 +105,9 @@ static int __maybe_unused atmel_flexcom_resume(struct device *dev) return 0; } -static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL, - atmel_flexcom_resume); +static const struct dev_pm_ops atmel_flexcom_pm_ops = { + .resume_noirq = atmel_flexcom_resume_noirq, +}; static struct platform_driver atmel_flexcom_driver = { .probe = atmel_flexcom_probe, -- 2.33.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq 2021-10-28 13:51 ` [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Claudiu Beznea @ 2021-11-24 15:36 ` Lee Jones 2022-01-10 15:38 ` Lee Jones 1 sibling, 0 replies; 6+ messages in thread From: Lee Jones @ 2021-11-24 15:36 UTC (permalink / raw) To: Claudiu Beznea Cc: nicolas.ferre, alexandre.belloni, ludovic.desroches, romain.izard.pro, linux-arm-kernel, linux-kernel, Codrin Ciubotariu On Thu, 28 Oct 2021, Claudiu Beznea wrote: > Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation > mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might > be connected critical devices (like PMIC) which on suspend/resume should > be suspended/resumed at the end/beginning. i2c uses > .suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom > to use .resume_noirq as it should be resumed before the embedded IPs. > Otherwise the embedded devices might behave badly. > > Fixes: 7fdec11015c3 ("atmel_flexcom: Support resuming after a chip reset") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Tested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/mfd/atmel-flexcom.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq 2021-10-28 13:51 ` [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Claudiu Beznea 2021-11-24 15:36 ` Lee Jones @ 2022-01-10 15:38 ` Lee Jones 1 sibling, 0 replies; 6+ messages in thread From: Lee Jones @ 2022-01-10 15:38 UTC (permalink / raw) To: Claudiu Beznea Cc: nicolas.ferre, alexandre.belloni, ludovic.desroches, romain.izard.pro, linux-arm-kernel, linux-kernel, Codrin Ciubotariu On Thu, 28 Oct 2021, Claudiu Beznea wrote: > Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation > mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might > be connected critical devices (like PMIC) which on suspend/resume should > be suspended/resumed at the end/beginning. i2c uses > .suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom > to use .resume_noirq as it should be resumed before the embedded IPs. > Otherwise the embedded devices might behave badly. > > Fixes: 7fdec11015c3 ("atmel_flexcom: Support resuming after a chip reset") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > Tested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/mfd/atmel-flexcom.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c > index 962f66dc8813..559eb4d352b6 100644 > --- a/drivers/mfd/atmel-flexcom.c > +++ b/drivers/mfd/atmel-flexcom.c > @@ -87,7 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match); > > -static int __maybe_unused atmel_flexcom_resume(struct device *dev) > +static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev) > { > struct atmel_flexcom *ddata = dev_get_drvdata(dev); > int err; > @@ -105,8 +105,9 @@ static int __maybe_unused atmel_flexcom_resume(struct device *dev) > return 0; > } > > -static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL, > - atmel_flexcom_resume); > +static const struct dev_pm_ops atmel_flexcom_pm_ops = { > + .resume_noirq = atmel_flexcom_resume_noirq, Doesn't this mean you can remove __maybe_unused? > +}; > > static struct platform_driver atmel_flexcom_driver = { > .probe = atmel_flexcom_probe, -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-10 15:38 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-28 13:51 [PATCH v2 0/2] mfd: atmel-flexcom: add a fix and code cosmetics Claudiu Beznea 2021-10-28 13:51 ` [PATCH v2 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP Claudiu Beznea 2021-11-24 15:35 ` Lee Jones 2021-10-28 13:51 ` [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Claudiu Beznea 2021-11-24 15:36 ` Lee Jones 2022-01-10 15:38 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).