* [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings
@ 2021-10-26 22:55 Rob Herring
2021-10-28 0:05 ` Frank Rowand
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-10-26 22:55 UTC (permalink / raw)
To: devicetree; +Cc: linux-kernel, Stephen Rothwell, Frank Rowand
The unittest dtbs have various intentional errors which cause warnings.
With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
some new checks: node_name_vs_property_name and interrupt_map warnings.
These warnings are also generated for static_base_1.dtb, so let's just
disable the problematic warnings for all unittest dtbs instead of just
testcases.dtb.
Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/of/unittest-data/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
index a5d2d9254b2c..7e1a25ad4e5c 100644
--- a/drivers/of/unittest-data/Makefile
+++ b/drivers/of/unittest-data/Makefile
@@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
DTC_FLAGS_testcases += -@
# suppress warnings about intentional errors
-DTC_FLAGS_testcases += -Wno-interrupts_property
+DTC_FLAGS += -Wno-interrupts_property \
+ -Wno-node_name_vs_property_name \
+ -Wno-interrupt_map
# Apply overlays statically with fdtoverlay. This is a build time test that
# the overlays can be applied successfully by fdtoverlay. This does not
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings
2021-10-26 22:55 [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings Rob Herring
@ 2021-10-28 0:05 ` Frank Rowand
2021-10-28 4:37 ` Stephen Rothwell
2021-10-28 12:54 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Frank Rowand @ 2021-10-28 0:05 UTC (permalink / raw)
To: Rob Herring, devicetree; +Cc: linux-kernel, Stephen Rothwell
On 10/26/21 5:55 PM, Rob Herring wrote:
> The unittest dtbs have various intentional errors which cause warnings.
> With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
> some new checks: node_name_vs_property_name and interrupt_map warnings.
>
> These warnings are also generated for static_base_1.dtb, so let's just
> disable the problematic warnings for all unittest dtbs instead of just
> testcases.dtb.
>
> Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/of/unittest-data/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
> index a5d2d9254b2c..7e1a25ad4e5c 100644
> --- a/drivers/of/unittest-data/Makefile
> +++ b/drivers/of/unittest-data/Makefile
> @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
> DTC_FLAGS_testcases += -@
>
> # suppress warnings about intentional errors
> -DTC_FLAGS_testcases += -Wno-interrupts_property
> +DTC_FLAGS += -Wno-interrupts_property \
> + -Wno-node_name_vs_property_name \
> + -Wno-interrupt_map
>
> # Apply overlays statically with fdtoverlay. This is a build time test that
> # the overlays can be applied successfully by fdtoverlay. This does not
>
Before applying this commit, I am not seeing the warning that -Wno-interrupt_map
suppresses. I've tried with (1) CONFIG_OF_DYNAMIC and (2) with both
CONFIG_OF_DYNAMIC and CONFIG_OF_OVERLAY, and I don't see the warning.
Where are you seeing the interrupt_map warning?
I would prefer not changing from DTC_FLAGS_testcases to DTC_FLAGS because
the suppresses the warning for all unittest .dts files, not just the two
that lead to the node_name_vs_property_name warning. These two cases can
be covered with DTC_FLAGS_testcases and DTC_FLAGS_static_test_1.
-Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings
2021-10-28 0:05 ` Frank Rowand
@ 2021-10-28 4:37 ` Stephen Rothwell
2021-10-28 12:54 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2021-10-28 4:37 UTC (permalink / raw)
To: Frank Rowand; +Cc: Rob Herring, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Hi Frank,
On Wed, 27 Oct 2021 19:05:22 -0500 Frank Rowand <frowand.list@gmail.com> wrote:
>
> Before applying this commit, I am not seeing the warning that -Wno-interrupt_map
> suppresses. I've tried with (1) CONFIG_OF_DYNAMIC and (2) with both
> CONFIG_OF_DYNAMIC and CONFIG_OF_OVERLAY, and I don't see the warning.
>
> Where are you seeing the interrupt_map warning?
Original report here:
https://lore.kernel.org/all/20211026134417.1be98b56@canb.auug.org.au/
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings
2021-10-28 0:05 ` Frank Rowand
2021-10-28 4:37 ` Stephen Rothwell
@ 2021-10-28 12:54 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-10-28 12:54 UTC (permalink / raw)
To: Frank Rowand; +Cc: devicetree, linux-kernel, Stephen Rothwell
On Wed, Oct 27, 2021 at 7:05 PM Frank Rowand <frowand.list@gmail.com> wrote:
>
> On 10/26/21 5:55 PM, Rob Herring wrote:
> > The unittest dtbs have various intentional errors which cause warnings.
> > With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
> > some new checks: node_name_vs_property_name and interrupt_map warnings.
> >
> > These warnings are also generated for static_base_1.dtb, so let's just
> > disable the problematic warnings for all unittest dtbs instead of just
> > testcases.dtb.
> >
> > Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Frank Rowand <frowand.list@gmail.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/of/unittest-data/Makefile | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
> > index a5d2d9254b2c..7e1a25ad4e5c 100644
> > --- a/drivers/of/unittest-data/Makefile
> > +++ b/drivers/of/unittest-data/Makefile
> > @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
> > DTC_FLAGS_testcases += -@
> >
> > # suppress warnings about intentional errors
> > -DTC_FLAGS_testcases += -Wno-interrupts_property
> > +DTC_FLAGS += -Wno-interrupts_property \
> > + -Wno-node_name_vs_property_name \
> > + -Wno-interrupt_map
> >
> > # Apply overlays statically with fdtoverlay. This is a build time test that
> > # the overlays can be applied successfully by fdtoverlay. This does not
> >
>
> Before applying this commit, I am not seeing the warning that -Wno-interrupt_map
> suppresses. I've tried with (1) CONFIG_OF_DYNAMIC and (2) with both
> CONFIG_OF_DYNAMIC and CONFIG_OF_OVERLAY, and I don't see the warning.
>
> Where are you seeing the interrupt_map warning?
I should have noted that that is dependent on re-enabling the
interrupt_provider warning which was dependent on the dtc changes.
I've already submitted dts fixes for that and plan to enable soon:
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 56d50eb0cd80..d435db2222ab 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -305,7 +305,6 @@ quiet_cmd_gzip = GZIP $@
# DTC
# ---------------------------------------------------------------------------
DTC ?= $(objtree)/scripts/dtc/dtc
-DTC_FLAGS += -Wno-interrupt_provider
# Disable noisy checks by default
ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
@@ -319,8 +318,7 @@ endif
ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
DTC_FLAGS += -Wnode_name_chars_strict \
- -Wproperty_name_chars_strict \
- -Winterrupt_provider
+ -Wproperty_name_chars_strict
endif
DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
(I just noticed that dtc doesn't seem to handle overriding options
such as: '-Wno-interrupt_provider -Winterrupt_provider')
> I would prefer not changing from DTC_FLAGS_testcases to DTC_FLAGS because
> the suppresses the warning for all unittest .dts files, not just the two
> that lead to the node_name_vs_property_name warning. These two cases can
> be covered with DTC_FLAGS_testcases and DTC_FLAGS_static_test_1.
Okay.
Rob
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-28 12:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 22:55 [PATCH] of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings Rob Herring
2021-10-28 0:05 ` Frank Rowand
2021-10-28 4:37 ` Stephen Rothwell
2021-10-28 12:54 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).