* [PATCH] scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON
@ 2021-10-28 20:35 Julian Braha
2021-10-29 3:59 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Julian Braha @ 2021-10-28 20:35 UTC (permalink / raw)
To: alim.akhtar, avri.altman, jejb, martin.petersen, beanhuo,
rdunlap, daejun7.park
Cc: fazilyildiran, linux-scsi, linux-kernel
When RESET_TI_SYSCON is selected, and RESET_CONTROLLER
is not selected, Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
Selected by [y]:
- SCSI_UFS_MEDIATEK [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
This is because RESET_TI_SYSCON is selected by
SCSI_UFS_MEDIATEK, but SCSI_UFS_MEDIATEK does
not select or depend on RESET_CONTROLLER, despite
RESET_TI_SYSCON depending on RESET_CONTROLLER.
These unmet dependency bugs were detected by Kismet,
a static analysis tool for Kconfig. Please advise if this
is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/scsi/ufs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index b2521b830be7..0427f8277a5d 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK
tristate "Mediatek specific hooks to UFS controller platform driver"
depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
select PHY_MTK_UFS
+ select RESET_CONTROLLER
select RESET_TI_SYSCON
help
This selects the Mediatek specific additions to UFSHCD platform driver.
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON
2021-10-28 20:35 [PATCH] scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON Julian Braha
@ 2021-10-29 3:59 ` Bart Van Assche
2021-10-29 20:13 ` Julian Braha
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2021-10-29 3:59 UTC (permalink / raw)
To: Julian Braha, alim.akhtar, avri.altman, jejb, martin.petersen,
beanhuo, rdunlap, daejun7.park
Cc: fazilyildiran, linux-scsi, linux-kernel
On 10/28/21 13:35, Julian Braha wrote:
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index b2521b830be7..0427f8277a5d 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK
> tristate "Mediatek specific hooks to UFS controller platform driver"
> depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
> select PHY_MTK_UFS
> + select RESET_CONTROLLER
> select RESET_TI_SYSCON
> help
> This selects the Mediatek specific additions to UFSHCD platform driver.
Please keep the indentation consistent.
Thanks,
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON
2021-10-29 3:59 ` Bart Van Assche
@ 2021-10-29 20:13 ` Julian Braha
0 siblings, 0 replies; 3+ messages in thread
From: Julian Braha @ 2021-10-29 20:13 UTC (permalink / raw)
To: Bart Van Assche
Cc: alim.akhtar, avri.altman, jejb, martin.petersen, beanhuo,
rdunlap, daejun7.park, fazilyildiran, linux-scsi, linux-kernel
> Please keep the indentation consistent.
>
> Thanks,
>
> Bart.
>
Hi Bart,
I have adjusted my text editor, and will resubmit the patch.
- Julian Braha
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-29 20:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28 20:35 [PATCH] scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON Julian Braha
2021-10-29 3:59 ` Bart Van Assche
2021-10-29 20:13 ` Julian Braha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).