From: kernel test robot <lkp@intel.com>
To: cgel.zte@gmail.com, gregkh@linuxfoundation.org
Cc: kbuild-all@lists.01.org, jirislaby@kernel.org, johan@kernel.org,
macro@orcam.me.uk, fancer.lancer@gmail.com, andrew@aj.id.au,
pali@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, Jing Yao <yao.jing2@zte.com.cn>
Subject: Re: [PATCH] drivers: tty: replace snprintf in show functions with sysfs_emit
Date: Fri, 29 Oct 2021 07:49:15 +0800 [thread overview]
Message-ID: <202110290741.7N3hOTAU-lkp@intel.com> (raw)
In-Reply-To: <20211028101350.14172-1-yao.jing2@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 3535 bytes --]
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on staging/staging-testing v5.15-rc7 next-20211028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/drivers-tty-replace-snprintf-in-show-functions-with-sysfs_emit/20211028-181624
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: microblaze-buildonly-randconfig-r002-20211028 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/03b103ac2507a7958ac9e45fe6a53110e1140625
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review cgel-zte-gmail-com/drivers-tty-replace-snprintf-in-show-functions-with-sysfs_emit/20211028-181624
git checkout 03b103ac2507a7958ac9e45fe6a53110e1140625
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/mm_types_task.h:16,
from include/linux/mm_types.h:5,
from include/linux/buildid.h:5,
from include/linux/module.h:14,
from drivers/tty/serial/8250/8250_port.c:14:
drivers/tty/serial/8250/8250_port.c: In function 'rx_trig_bytes_show':
>> arch/microblaze/include/asm/page.h:24:25: error: passing argument 2 of 'sysfs_emit' makes pointer from integer without a cast [-Werror=int-conversion]
24 | #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| long unsigned int
drivers/tty/serial/8250/8250_port.c:3102:32: note: in expansion of macro 'PAGE_SIZE'
3102 | return sysfs_emit(buf, PAGE_SIZE, "%d\n", rxtrig_bytes);
| ^~~~~~~~~
In file included from include/linux/kobject.h:20,
from include/linux/module.h:21,
from drivers/tty/serial/8250/8250_port.c:14:
include/linux/sysfs.h:341:39: note: expected 'const char *' but argument is of type 'long unsigned int'
341 | int sysfs_emit(char *buf, const char *fmt, ...);
| ~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors
vim +/sysfs_emit +24 arch/microblaze/include/asm/page.h
4b87d7a4f91d31 Michal Simek 2009-03-27 21
4b87d7a4f91d31 Michal Simek 2009-03-27 22 /* PAGE_SHIFT determines the page size */
ba9c4f88d74783 Steven J. Magnani 2010-05-13 23 #define PAGE_SHIFT 12
ba9c4f88d74783 Steven J. Magnani 2010-05-13 @24 #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT)
4b87d7a4f91d31 Michal Simek 2009-03-27 25 #define PAGE_MASK (~(PAGE_SIZE-1))
4b87d7a4f91d31 Michal Simek 2009-03-27 26
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34791 bytes --]
next prev parent reply other threads:[~2021-10-28 23:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 10:13 [PATCH] drivers: tty: replace snprintf in show functions with sysfs_emit cgel.zte
2021-10-28 12:22 ` Johan Hovold
2021-10-28 12:49 ` Maciej W. Rozycki
2021-10-28 20:57 ` kernel test robot
2021-10-28 23:49 ` kernel test robot [this message]
2021-10-29 5:44 ` Greg KH
2021-10-31 15:34 ` Joe Perches
2021-11-02 6:52 ` [PATCH v2] " cgel.zte
2021-11-02 7:44 ` Johan Hovold
2021-11-04 11:47 ` [PATCH v3] serial: 8250: " cgel.zte
2021-11-08 9:54 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110290741.7N3hOTAU-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@aj.id.au \
--cc=cgel.zte@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=pali@kernel.org \
--cc=yao.jing2@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).