linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Johan Hovold <johan@kernel.org>
Cc: cgel.zte@gmail.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	jirislaby@kernel.org, fancer.lancer@gmail.com, andrew@aj.id.au,
	pali@kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jing Yao <yao.jing2@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers: tty: replace snprintf in show functions with sysfs_emit
Date: Thu, 28 Oct 2021 13:49:22 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2110281342290.61663@angie.orcam.me.uk> (raw)
In-Reply-To: <YXqV9V0eWhqFTc+i@hovoldconsulting.com>

On Thu, 28 Oct 2021, Johan Hovold wrote:

> Where's the commit message?

 Or to put it explicitly: please always include a full description of any 
change submitted, where you explain what your change is needed for and why 
you have made it like this.

 Please refer to Documentation/process/submitting-patches.rst in the 
source tree for a full recipe for submitting patches, which says, among 
others:

"[...] The text should be written in such detail so that when read
weeks, months or even years later, it can give the reader the needed
details to grasp the reasoning for **why** the patch was created."

 Thanks,

  Maciej

  reply	other threads:[~2021-10-28 12:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 10:13 [PATCH] drivers: tty: replace snprintf in show functions with sysfs_emit cgel.zte
2021-10-28 12:22 ` Johan Hovold
2021-10-28 12:49   ` Maciej W. Rozycki [this message]
2021-10-28 20:57 ` kernel test robot
2021-10-28 23:49 ` kernel test robot
2021-10-29  5:44 ` Greg KH
2021-10-31 15:34   ` Joe Perches
2021-11-02  6:52     ` [PATCH v2] " cgel.zte
2021-11-02  7:44       ` Johan Hovold
2021-11-04 11:47         ` [PATCH v3] serial: 8250: " cgel.zte
2021-11-08  9:54           ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2110281342290.61663@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=andrew@aj.id.au \
    --cc=cgel.zte@gmail.com \
    --cc=fancer.lancer@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=yao.jing2@zte.com.cn \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).