From: Leo Yan <leo.yan@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
James Clark <james.clark@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator
Date: Mon, 1 Nov 2021 18:59:36 +0800 [thread overview]
Message-ID: <20211101105936.GA352474@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <df07c7b0-0145-8290-b4cd-a1831f19330d@arm.com>
Hi Suzuki,
On Mon, Nov 01, 2021 at 09:49:06AM +0000, Suzuki Kuruppassery Poulose wrote:
> Hi Leo
>
> On 31/10/2021 14:42, Leo Yan wrote:
> > When read the virtual context ID comparator value via sysfs node, the
> > driver firstly reads out the index, then reads the comparator value
> > based on index. >
> > This patch adds the spinlock to protect the atomicity for up two steps.
>
> minor nit: This could be :
>
> "Updates to the values and the index are protected via the
> spinlock. Ensure we use the same lock to read the value
> safely"
Yeah, this is more simple and clear. Will use it.
> With that:
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Thanks for review.
Leo
next prev parent reply other threads:[~2021-11-01 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 14:42 [PATCH v1 0/4] coresight: etm: Correct (virtual) contextID tracing for namespace Leo Yan
2021-10-31 14:42 ` [PATCH v1 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator Leo Yan
2021-11-01 9:49 ` Suzuki K Poulose
2021-11-01 10:59 ` Leo Yan [this message]
2021-10-31 14:42 ` [PATCH v1 2/4] coresight: etm4x: Don't use virtual contextID for non-root PID namespace Leo Yan
2021-11-04 15:07 ` Suzuki K Poulose
2021-11-04 15:24 ` Leo Yan
2021-10-31 14:42 ` [PATCH v1 3/4] coresight: etm4x: Don't trace contextID for non-root namespace in perf mode Leo Yan
2021-11-16 9:46 ` Suzuki K Poulose
2021-11-17 13:53 ` Leo Yan
2021-10-31 14:42 ` [PATCH v1 4/4] coresight: etm3x: " Leo Yan
2021-11-16 13:52 ` [PATCH v1 0/4] coresight: etm: Correct (virtual) contextID tracing for namespace Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101105936.GA352474@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).