From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Leo Yan <leo.yan@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
James Clark <james.clark@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/4] coresight: etm: Correct (virtual) contextID tracing for namespace
Date: Tue, 16 Nov 2021 13:52:52 +0000 [thread overview]
Message-ID: <c716be29-4f0c-b516-c0bf-dc89ba466885@arm.com> (raw)
In-Reply-To: <20211031144214.237879-1-leo.yan@linaro.org>
Hi Leo
On 31/10/2021 14:42, Leo Yan wrote:
> If a profiling program runs in a non-root PID namespace, if CoreSight
> driver enables contextID tracing, it can lead to mismatching issue
> between the context ID in hardware trace data and the allocated PID in
> the non-root namespace.
>
> CoreSight driver has tried to address this issue for the contextID
> related interfaces under sysfs, but it misses other parts: it doesn't
> prevent user to set VMID (virtual contextID) for kernel runs in EL2 with
> VHE, and furthermore, it misses to handle the perf mode when the
> profiling tool (e.g. perf) doesn't run in root PID namespace.
>
> For this reason, this patch series is to correct contextID tracing for
> non-root namespace.
>
> Patch 01 is to use spinlock to protect reading virtual context ID
> comparator.
>
> Patch 02 corrects the virtual contextID tracing for non-root PID
> namespace.
>
> Patch 03/04 are used to fix the contextID tracing for perf mode.
>
> I only verified this patch series on Juno board in the root PID
> namespace and confirmed the patches don't introduce any regression for
> root PID namespace.
>
I have finished reviewing the set.
Suzuki
prev parent reply other threads:[~2021-11-16 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 14:42 [PATCH v1 0/4] coresight: etm: Correct (virtual) contextID tracing for namespace Leo Yan
2021-10-31 14:42 ` [PATCH v1 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator Leo Yan
2021-11-01 9:49 ` Suzuki K Poulose
2021-11-01 10:59 ` Leo Yan
2021-10-31 14:42 ` [PATCH v1 2/4] coresight: etm4x: Don't use virtual contextID for non-root PID namespace Leo Yan
2021-11-04 15:07 ` Suzuki K Poulose
2021-11-04 15:24 ` Leo Yan
2021-10-31 14:42 ` [PATCH v1 3/4] coresight: etm4x: Don't trace contextID for non-root namespace in perf mode Leo Yan
2021-11-16 9:46 ` Suzuki K Poulose
2021-11-17 13:53 ` Leo Yan
2021-10-31 14:42 ` [PATCH v1 4/4] coresight: etm3x: " Leo Yan
2021-11-16 13:52 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c716be29-4f0c-b516-c0bf-dc89ba466885@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).