From: Jakub Kicinski <kuba@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
keescook@chromium.org, kvalo@codeaurora.org,
miriam.rachel.korenblit@intel.com
Subject: Re: [GIT PULL] Networking for 5.16
Date: Tue, 2 Nov 2021 07:10:51 -0700 [thread overview]
Message-ID: <20211102071051.15a89ab6@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <CAHk-=wgdE6=ob5nF60GvRYAG24MKaJBGJf3jPufMe1k_UPBQTA@mail.gmail.com>
On Tue, 2 Nov 2021 06:20:35 -0700 Linus Torvalds wrote:
> On Mon, Nov 1, 2021 at 10:43 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-for-5.16
>
> I get quite a lot of
>
> ./scripts/pahole-flags.sh: line 7: return: can only `return' from
> a function or sourced script
>
> with this. Why didn't anybopdy else notice? It seems entirely bogus
> and presumably happens everywhere else too.
>
> It's shell script. You don't "return" from it. You "exit" from it.
>
> Grr.
Sorry about that.
Looks like the patch was merged on Friday, presumably nobody tried
to build -next without pahole installed on their system since.
Let me correct for that by sending the PR on Tue next merge window.
Hopefully an extra day will be enough for someone to catch silly
mistakes like this. I had to do a last minute TCP revert as well,
so yeah, seems like Monday was a little rushed on my side.
next prev parent reply other threads:[~2021-11-02 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 5:42 [GIT PULL] Networking for 5.16 Jakub Kicinski
2021-11-02 13:20 ` Linus Torvalds
2021-11-02 13:30 ` Jiri Olsa
2021-11-02 13:32 ` Linus Torvalds
2021-11-02 13:57 ` Jiri Olsa
2021-11-02 14:10 ` Jakub Kicinski [this message]
2021-11-02 14:46 ` pr-tracker-bot
2021-11-02 15:24 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102071051.15a89ab6@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=davem@davemloft.net \
--cc=jolsa@kernel.org \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).