* [PATCH v3] drivers: mtd: Fixed breaking list in __mtd_del_partition.
@ 2021-11-02 17:26 Andreas Oetken
2021-11-19 18:35 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Oetken @ 2021-11-02 17:26 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: Andreas Oetken, linux-mtd, linux-kernel, Andreas Oetken, stable
Not the child partition should be removed from the partition list
but the partition itself. Otherwise the partition list gets broken
and any subsequent remove operations leads to a kernel panic.
Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com>
Cc: stable@vger.kernel.org
---
drivers/mtd/mtdpart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 95d47422bbf20..5725818fa199f 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mtd_info *mtd)
if (err)
return err;
- list_del(&child->part.node);
+ list_del(&mtd->part.node);
free_partition(mtd);
return 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] drivers: mtd: Fixed breaking list in __mtd_del_partition.
2021-11-02 17:26 [PATCH v3] drivers: mtd: Fixed breaking list in __mtd_del_partition Andreas Oetken
@ 2021-11-19 18:35 ` Miquel Raynal
0 siblings, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2021-11-19 18:35 UTC (permalink / raw)
To: Andreas Oetken, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Andreas Oetken, stable
On Tue, 2021-11-02 at 17:26:04 UTC, Andreas Oetken wrote:
> Not the child partition should be removed from the partition list
> but the partition itself. Otherwise the partition list gets broken
> and any subsequent remove operations leads to a kernel panic.
>
> Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
> Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com>
> Cc: stable@vger.kernel.org
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3] drivers: mtd: Fixed breaking list in __mtd_del_partition.
@ 2021-10-26 8:49 Andreas Oetken
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Oetken @ 2021-10-26 8:49 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: Andreas Oetken, linux-mtd, linux-kernel, Andreas Oetken, stable
Not the child partition should be removed from the partition list
but the partition itself. Otherwise the partition list gets broken
and any subsequent remove operations leads to a kernel panic.
Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com>
Cc: stable@vger.kernel.org
---
drivers/mtd/mtdpart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 95d47422bbf20..5725818fa199f 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mtd_info *mtd)
if (err)
return err;
- list_del(&child->part.node);
+ list_del(&mtd->part.node);
free_partition(mtd);
return 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-19 18:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 17:26 [PATCH v3] drivers: mtd: Fixed breaking list in __mtd_del_partition Andreas Oetken
2021-11-19 18:35 ` Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2021-10-26 8:49 Andreas Oetken
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).