* [PATCH] s390:Use BUG_ON instead of if condition followed by BUG.
@ 2021-11-03 5:56 cgel.zte
2021-11-10 14:44 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2021-11-03 5:56 UTC (permalink / raw)
To: hca
Cc: gor, borntraeger, agordeev, svens, egorenar, geert, zhang.mingyu,
frankja, ebiederm, linux-s390, linux-kernel, Zeal Robot
From: Zhang Mingyu <zhang.mingyu@zte.com.cn>
This issue was detected with the help of Coccinelle.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Zhang Mingyu <zhang.mingyu@zte.com.cn>
---
arch/s390/mm/fault.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
index d30f5986fa85..48a0231158c9 100644
--- a/arch/s390/mm/fault.c
+++ b/arch/s390/mm/fault.c
@@ -824,8 +824,7 @@ void do_secure_storage_access(struct pt_regs *regs)
break;
rc = arch_make_page_accessible(page);
put_page(page);
- if (rc)
- BUG();
+ BUG_ON(rc);
break;
case GMAP_FAULT:
default:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390:Use BUG_ON instead of if condition followed by BUG.
2021-11-03 5:56 [PATCH] s390:Use BUG_ON instead of if condition followed by BUG cgel.zte
@ 2021-11-10 14:44 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2021-11-10 14:44 UTC (permalink / raw)
To: cgel.zte
Cc: gor, borntraeger, agordeev, svens, egorenar, geert, zhang.mingyu,
frankja, ebiederm, linux-s390, linux-kernel, Zeal Robot
On Wed, Nov 03, 2021 at 05:56:22AM +0000, cgel.zte@gmail.com wrote:
> From: Zhang Mingyu <zhang.mingyu@zte.com.cn>
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Zhang Mingyu <zhang.mingyu@zte.com.cn>
> ---
> arch/s390/mm/fault.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
S-O-B chain is incorrect. Sent by cgel.zte@gmail.com, but not listed
anywhere. Therefore not applying.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-10 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03 5:56 [PATCH] s390:Use BUG_ON instead of if condition followed by BUG cgel.zte
2021-11-10 14:44 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).