* [PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux channel
@ 2021-11-04 10:20 AngeloGioacchino Del Regno
2021-11-10 13:02 ` Dafna Hirschfeld
0 siblings, 1 reply; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2021-11-04 10:20 UTC (permalink / raw)
To: a.hajda
Cc: narmstrong, robert.foss, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, kernel, linux-kernel,
AngeloGioacchino Del Regno
As it was done with other bridge drivers and to solve a warning coming
from drm_dp_aux_register(), add a backpointer to drm_device in the
drm_dp_aux that we're registering.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/gpu/drm/bridge/parade-ps8640.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index 191cc196c9d1..20d8e606d543 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -455,6 +455,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
goto err_dsi_attach;
}
+ ps_bridge->aux.drm_dev = bridge->dev;
ret = drm_dp_aux_register(&ps_bridge->aux);
if (ret) {
dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux channel
2021-11-04 10:20 [PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux channel AngeloGioacchino Del Regno
@ 2021-11-10 13:02 ` Dafna Hirschfeld
0 siblings, 0 replies; 2+ messages in thread
From: Dafna Hirschfeld @ 2021-11-10 13:02 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, a.hajda
Cc: narmstrong, robert.foss, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, kernel, linux-kernel
On 04.11.21 12:20, AngeloGioacchino Del Regno wrote:
> As it was done with other bridge drivers and to solve a warning coming
> from drm_dp_aux_register(), add a backpointer to drm_device in the
> drm_dp_aux that we're registering.
>
it is common to dump the exact warning in the commit log so people can locate it later.
Maybe also add 'Fixes' tag?
apart of that
Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/gpu/drm/bridge/parade-ps8640.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 191cc196c9d1..20d8e606d543 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -455,6 +455,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
> goto err_dsi_attach;
> }
>
> + ps_bridge->aux.drm_dev = bridge->dev;
> ret = drm_dp_aux_register(&ps_bridge->aux);
> if (ret) {
> dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-10 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 10:20 [PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux channel AngeloGioacchino Del Regno
2021-11-10 13:02 ` Dafna Hirschfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).