linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: udp: correct the document for udp_mem
@ 2021-11-05  7:35 menglong8.dong
  2021-11-05 10:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: menglong8.dong @ 2021-11-05  7:35 UTC (permalink / raw)
  To: kuba; +Cc: davem, corbet, netdev, linux-doc, linux-kernel, Menglong Dong

From: Menglong Dong <imagedong@tencent.com>

udp_mem is a vector of 3 INTEGERs, which is used to limit the number of
pages allowed for queueing by all UDP sockets.

However, sk_has_memory_pressure() in __sk_mem_raise_allocated() always
return false for udp, as memory pressure is not supported by udp, which
means that __sk_mem_raise_allocated() will fail once pages allocated
for udp socket exceeds udp_mem[0].

Therefor, udp_mem[0] is the only one that limit the number of pages.
However, the document of udp_mem just express that udp_mem[2] is the
limitation. So, just fix it.

Signed-off-by: Menglong Dong <imagedong@tencent.com>
---
 Documentation/networking/ip-sysctl.rst | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index d91ab28718d4..8edc1547170b 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -1012,13 +1012,11 @@ udp_l3mdev_accept - BOOLEAN
 udp_mem - vector of 3 INTEGERs: min, pressure, max
 	Number of pages allowed for queueing by all UDP sockets.
 
-	min: Below this number of pages UDP is not bothered about its
-	memory appetite. When amount of memory allocated by UDP exceeds
-	this number, UDP starts to moderate memory usage.
+	min: Number of pages allowed for queueing by all UDP sockets.
 
 	pressure: This value was introduced to follow format of tcp_mem.
 
-	max: Number of pages allowed for queueing by all UDP sockets.
+	max: This value was introduced to follow format of tcp_mem.
 
 	Default is calculated at boot time from amount of available memory.
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: udp: correct the document for udp_mem
  2021-11-05  7:35 [PATCH net-next] net: udp: correct the document for udp_mem menglong8.dong
@ 2021-11-05 10:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-05 10:50 UTC (permalink / raw)
  To: Menglong Dong
  Cc: kuba, davem, corbet, netdev, linux-doc, linux-kernel, imagedong

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri,  5 Nov 2021 15:35:41 +0800 you wrote:
> From: Menglong Dong <imagedong@tencent.com>
> 
> udp_mem is a vector of 3 INTEGERs, which is used to limit the number of
> pages allowed for queueing by all UDP sockets.
> 
> However, sk_has_memory_pressure() in __sk_mem_raise_allocated() always
> return false for udp, as memory pressure is not supported by udp, which
> means that __sk_mem_raise_allocated() will fail once pages allocated
> for udp socket exceeds udp_mem[0].
> 
> [...]

Here is the summary with links:
  - [net-next] net: udp: correct the document for udp_mem
    https://git.kernel.org/netdev/net/c/69dfccbc1186

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-05 10:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05  7:35 [PATCH net-next] net: udp: correct the document for udp_mem menglong8.dong
2021-11-05 10:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).