[PATCH 0/2] staging: r8188eu: MSG_88E cleanup series

[PATCH 0/2] staging: r8188eu: MSG_88E cleanup series

[Phillip Potter]

This small patch series converts the last two callers of MSG_88E to
netdev_dbg, as the information may be of interest to users/developers so
I didn't just want to delete them outright. It also then removes the
MSG_88E macro from the drivers, as part of the ongoing macro cleanup.

Phillip Potter (2):
  staging: r8188eu: convert final two MSG_88E calls to netdev_dbg
  staging: r8188eu: remove MSG_88E macro

 drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 +++--
 drivers/staging/r8188eu/include/rtw_debug.h     | 6 ------
 2 files changed, 3 insertions(+), 8 deletions(-)

-- 
2.31.1

[PATCH 1/2] staging: r8188eu: convert final two MSG_88E calls to netdev_dbg

[Phillip Potter]

Convert final two MSG_88E calls to use netdev_dbg instead. They seem to
contain useful information so rather than delete them outright, it makes
sense to convert them over to use the kernel's dynamic debugging/logging
facility as other network drivers do.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---
 drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
index 8c00f2dd67da..c12c3b37d889 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
@@ -1660,7 +1660,7 @@ void rtl8188e_read_chip_version(struct adapter *padapter)
 
 	pHalData->rf_type = RF_1T1R;
 
-	MSG_88E("RF_Type is %x!!\n", pHalData->rf_type);
+	netdev_dbg(padapter->pnetdev, "RF_Type is %x!!\n", pHalData->rf_type);
 }
 
 void rtl8188e_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet)
@@ -1713,7 +1713,8 @@ u8 GetEEPROMSize8188E(struct adapter *padapter)
 	/*  6: EEPROM used is 93C46, 4: boot from E-Fuse. */
 	size = (cr & BOOT_FROM_EEPROM) ? 6 : 4;
 
-	MSG_88E("EEPROM type is %s\n", size == 4 ? "E-FUSE" : "93C46");
+	netdev_dbg(padapter->pnetdev, "EEPROM type is %s\n",
+		   size == 4 ? "E-FUSE" : "93C46");
 
 	return size;
 }
-- 
2.31.1

[PATCH 2/2] staging: r8188eu: remove MSG_88E macro

[Phillip Potter]

Remove MSG_88E macro from include/rtw_debug.h, as it no longer has any
callers within the driver.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---
 drivers/staging/r8188eu/include/rtw_debug.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/r8188eu/include/rtw_debug.h b/drivers/staging/r8188eu/include/rtw_debug.h
index 0a77e3e73a45..39b69b9ad0a3 100644
--- a/drivers/staging/r8188eu/include/rtw_debug.h
+++ b/drivers/staging/r8188eu/include/rtw_debug.h
@@ -66,10 +66,4 @@ extern u32 GlobalDebugLevel;
 			pr_info(DRIVER_PREFIX __VA_ARGS__);		\
 	} while (0)
 
-#define MSG_88E(...)							\
-	do {								\
-		if (_drv_err_ <= GlobalDebugLevel)			\
-			pr_info(DRIVER_PREFIX __VA_ARGS__);			\
-	} while (0)
-
 #endif	/* __RTW_DEBUG_H__ */
-- 
2.31.1