* [PATCH] ALSA: missing check for possible NULL after the call to kstrdup
@ 2021-11-09 0:37 Austin Kim
2021-11-09 6:24 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Austin Kim @ 2021-11-09 0:37 UTC (permalink / raw)
To: tiwai, perex; +Cc: alsa-devel, linux-kernel, austin.kim
From: Austin Kim <austin.kim@lge.com>
If kcalloc() return NULL due to memory starvation, it is possible for
kstrdup() to return NULL in similar case. So add null check after the call
to kstrdup() is made.
Signed-off-by: Austin Kim <austin.kim@lge.com>
---
sound/synth/emux/emux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/synth/emux/emux.c b/sound/synth/emux/emux.c
index 49d1976a132c..6dab3c5bac00 100644
--- a/sound/synth/emux/emux.c
+++ b/sound/synth/emux/emux.c
@@ -88,7 +88,7 @@ int snd_emux_register(struct snd_emux *emu, struct snd_card *card, int index, ch
emu->name = kstrdup(name, GFP_KERNEL);
emu->voices = kcalloc(emu->max_voices, sizeof(struct snd_emux_voice),
GFP_KERNEL);
- if (emu->voices == NULL)
+ if ((emu->name == NULL) || (emu->voices == NULL))
return -ENOMEM;
/* create soundfont list */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: missing check for possible NULL after the call to kstrdup
2021-11-09 0:37 [PATCH] ALSA: missing check for possible NULL after the call to kstrdup Austin Kim
@ 2021-11-09 6:24 ` Takashi Iwai
2021-11-09 8:20 ` Austin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2021-11-09 6:24 UTC (permalink / raw)
To: Austin Kim; +Cc: tiwai, perex, alsa-devel, linux-kernel, austin.kim
On Tue, 09 Nov 2021 01:37:42 +0100,
Austin Kim wrote:
>
> From: Austin Kim <austin.kim@lge.com>
>
> If kcalloc() return NULL due to memory starvation, it is possible for
> kstrdup() to return NULL in similar case. So add null check after the call
> to kstrdup() is made.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>
Thanks, applied now with a minor coding-style fix (we need no extra
parentheses), the correction of the subject line with the proper
prefix, and the addition of Cc-to-stable.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: missing check for possible NULL after the call to kstrdup
2021-11-09 6:24 ` Takashi Iwai
@ 2021-11-09 8:20 ` Austin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Austin Kim @ 2021-11-09 8:20 UTC (permalink / raw)
To: Takashi Iwai
Cc: tiwai, perex, alsa-devel, Linux Kernel Mailing List,
김동현
2021년 11월 9일 (화) 오후 3:24, Takashi Iwai <tiwai@suse.de>님이 작성:
>
> On Tue, 09 Nov 2021 01:37:42 +0100,
> Austin Kim wrote:
> >
> > From: Austin Kim <austin.kim@lge.com>
> >
> > If kcalloc() return NULL due to memory starvation, it is possible for
> > kstrdup() to return NULL in similar case. So add null check after the call
> > to kstrdup() is made.
> >
> > Signed-off-by: Austin Kim <austin.kim@lge.com>
>
> Thanks, applied now with a minor coding-style fix (we need no extra
> parentheses), the correction of the subject line with the proper
> prefix, and the addition of Cc-to-stable.
>
Great, Thanks
BR,
Austin Kim
>
> Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-09 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 0:37 [PATCH] ALSA: missing check for possible NULL after the call to kstrdup Austin Kim
2021-11-09 6:24 ` Takashi Iwai
2021-11-09 8:20 ` Austin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).