* [PATCH] [PATCH v2] ARM: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE
@ 2021-11-09 6:03 Julian Braha
2021-11-09 7:57 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2021-11-09 6:03 UTC (permalink / raw)
To: linux, arnd, linus.walleij, geert+renesas, mark.rutland, akpm
Cc: linux-arm-kernel, linux-kernel, fazilyildiran
When ARM is enabled, and BITREVERSE is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for HAVE_ARCH_BITREVERSE
Depends on [n]: BITREVERSE [=n]
Selected by [y]:
- ARM [=y] && (CPU_32v7M [=n] || CPU_32v7 [=y]) && !CPU_32v6 [=n]
This is because ARM selects HAVE_ARCH_BITREVERSE
without selecting BITREVERSE, despite
HAVE_ARCH_BITREVERSE depending on BITREVERSE.
This unmet dependency bug was found by Kismet,
a static analysis tool for Kconfig. Please advise if this
is not the appropriate solution.
v2:
Changed this fix to remove the dependency on BITREVERSE from
HAVE_ARCH_BITREVERSE, since it isn't actually necessary.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
lib/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index 6a6ae5312fa0..22975a87fef8 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -45,7 +45,6 @@ config BITREVERSE
config HAVE_ARCH_BITREVERSE
bool
default n
- depends on BITREVERSE
help
This option enables the use of hardware bit-reversal instructions on
architectures which support such operations.
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [PATCH v2] ARM: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE
2021-11-09 6:03 [PATCH] [PATCH v2] ARM: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE Julian Braha
@ 2021-11-09 7:57 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2021-11-09 7:57 UTC (permalink / raw)
To: Julian Braha
Cc: Russell King - ARM Linux, Arnd Bergmann, Linus Walleij,
Geert Uytterhoeven, Mark Rutland, Andrew Morton, Linux ARM,
Linux Kernel Mailing List, fazilyildiran
On Tue, Nov 9, 2021 at 7:03 AM Julian Braha <julianbraha@gmail.com> wrote:
>
> When ARM is enabled, and BITREVERSE is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for HAVE_ARCH_BITREVERSE
> Depends on [n]: BITREVERSE [=n]
> Selected by [y]:
> - ARM [=y] && (CPU_32v7M [=n] || CPU_32v7 [=y]) && !CPU_32v6 [=n]
>
> This is because ARM selects HAVE_ARCH_BITREVERSE
> without selecting BITREVERSE, despite
> HAVE_ARCH_BITREVERSE depending on BITREVERSE.
>
> This unmet dependency bug was found by Kismet,
> a static analysis tool for Kconfig.
Looks good to me, please add it to the patch tracker[1].
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Please advise if this
> is not the appropriate solution.
>
> v2:
> Changed this fix to remove the dependency on BITREVERSE from
> HAVE_ARCH_BITREVERSE, since it isn't actually necessary.
This bit should go below the --- line. You can also add a Link: tag
pointing to v1 [2].
Arnd
[1] https://www.armlinux.org.uk/developer/patches/info.php
[2] https://lore.kernel.org/linux-arm-kernel/20211029203110.8343-1-julianbraha@gmail.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-09 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 6:03 [PATCH] [PATCH v2] ARM: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE Julian Braha
2021-11-09 7:57 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).