linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, steev@kali.org,
	sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com,
	linux@armlinux.org.uk, gregkh@linuxfoundation.org,
	rafael@kernel.org, amitk@kernel.org, daniel.lezcano@linaro.org,
	amit.kachhap@gmail.com, thara.gopinath@linaro.org,
	bjorn.andersson@linaro.org, agross@kernel.org
Subject: Re: [PATCH v4 0/5] Refactor thermal pressure update to avoid code duplication
Date: Thu, 11 Nov 2021 08:45:35 +0530	[thread overview]
Message-ID: <20211111031535.nvrngqqffdmw2jgz@vireshk-i7> (raw)
In-Reply-To: <20211109195714.7750-1-lukasz.luba@arm.com>

On 09-11-21, 19:57, Lukasz Luba wrote:
> Hi all,
> 
> This patch set v4 aims to refactor the thermal pressure update
> code. There are already two clients which do similar thing:
> convert the capped frequency value into the capacity of
> affected CPU and call the 'set' function to store the 
> reduced capacity into the per-cpu variable.
> There might be more than two of these users. In near future
> it will be scmi-cpufreq driver, which receives notification
> from FW about reduced frequency due to thermal. Other vendors
> might follow. Let's avoid code duplication and potential
> conversion bugs. Move the conversion code into the arch_topology.c
> where the capacity calculation setup code and thermal pressure sit.
> 
> Apart from that $subject patches, there is one patch (3/5) which fixes
> issue in qcom-cpufreq-hw.c when the thermal pressure is not 
> updated for offline CPUs. It's similar fix that has been merged
> recently for cpufreq_cooling.c:
> 2ad8ccc17d1e4270cf65a3f2
> 
> The patch 4/5 fixes also qcom-cpufreq-hw.c driver code which did
> the translation from frequency to capacity wrongly when there
> was a boost frequency available and stored in 'policy->cpuinfo.max_freq'.

LGTM. I will apply this in a few days so people get time to Ack/Review
the patches.

-- 
viresh

  parent reply	other threads:[~2021-11-11  3:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 19:57 [PATCH v4 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 1/5] arch_topology: Introduce thermal pressure update function Lukasz Luba
2021-11-16 23:39   ` Thara Gopinath
2021-11-23  9:09     ` Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 2/5] thermal: cpufreq_cooling: Use new " Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 3/5] cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 4/5] cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function Lukasz Luba
2021-11-15 20:57   ` Thara Gopinath
2021-11-15 23:39     ` Thara Gopinath
2021-11-16  8:28       ` Lukasz Luba
2021-11-16  8:30     ` Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related Lukasz Luba
2021-11-11  3:15 ` Viresh Kumar [this message]
2021-11-23  9:11   ` [PATCH v4 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-11-23  9:45 ` Viresh Kumar
2021-11-23  9:46   ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211111031535.nvrngqqffdmw2jgz@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=agross@kernel.org \
    --cc=amit.kachhap@gmail.com \
    --cc=amitk@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=steev@kali.org \
    --cc=sudeep.holla@arm.com \
    --cc=thara.gopinath@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).