From: Lukasz Luba <lukasz.luba@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, steev@kali.org,
sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com,
linux@armlinux.org.uk, gregkh@linuxfoundation.org,
rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org,
daniel.lezcano@linaro.org, amit.kachhap@gmail.com,
bjorn.andersson@linaro.org, agross@kernel.org
Subject: Re: [PATCH v4 4/5] cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function
Date: Tue, 16 Nov 2021 08:28:53 +0000 [thread overview]
Message-ID: <6d667cef-3c37-7c8f-bc69-da907ac06e3f@arm.com> (raw)
In-Reply-To: <911760d9-b137-5c79-d072-c2f473a3cc6a@linaro.org>
Hi Thara,
On 11/15/21 11:39 PM, Thara Gopinath wrote:
>
>
> On 11/15/21 3:57 PM, Thara Gopinath wrote:
>>
>>
>> On 11/9/21 2:57 PM, Lukasz Luba wrote:
>>> Thermal pressure provides a new API, which allows to use CPU frequency
>>> as an argument. That removes the need of local conversion to capacity.
>>> Use this new API and remove old local conversion code.
>>>
>>> The new arch_update_thermal_pressure() also accepts boost frequencies,
>>> which solves issue in the driver code with wrong reduced capacity
>>> calculation. The reduced capacity was calculated wrongly due to
>>> 'policy->cpuinfo.max_freq' used as a divider. The value present there
>>> was
>>> actually the boost frequency. Thus, even a normal maximum frequency
>>> value
>>> which corresponds to max CPU capacity (arch_scale_cpu_capacity(cpu_id))
>>> is not able to remove the capping.
>
> Also I failed to mention that, currently freq_factor is initialized as
> cpuinfo.max_freq / 1000 which means again all the issues you mentioned
> below can be hit, if some cpufreq driver decides to set boost at init.
> I have sent a patch earlier today to fix this.
Yes, you are right.
>
> https://lore.kernel.org/linux-arm-msm/20211115201010.68567-1-thara.gopinath@linaro.org/T/#u
>
>
Looking at the change, it makes sense. I'll try to respond to that
patch.
Thank you for looking into this issue.
Regards,
Lukasz
next prev parent reply other threads:[~2021-11-16 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 19:57 [PATCH v4 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 1/5] arch_topology: Introduce thermal pressure update function Lukasz Luba
2021-11-16 23:39 ` Thara Gopinath
2021-11-23 9:09 ` Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 2/5] thermal: cpufreq_cooling: Use new " Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 3/5] cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 4/5] cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function Lukasz Luba
2021-11-15 20:57 ` Thara Gopinath
2021-11-15 23:39 ` Thara Gopinath
2021-11-16 8:28 ` Lukasz Luba [this message]
2021-11-16 8:30 ` Lukasz Luba
2021-11-09 19:57 ` [PATCH v4 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related Lukasz Luba
2021-11-11 3:15 ` [PATCH v4 0/5] Refactor thermal pressure update to avoid code duplication Viresh Kumar
2021-11-23 9:11 ` Lukasz Luba
2021-11-23 9:45 ` Viresh Kumar
2021-11-23 9:46 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d667cef-3c37-7c8f-bc69-da907ac06e3f@arm.com \
--to=lukasz.luba@arm.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rafael@kernel.org \
--cc=steev@kali.org \
--cc=sudeep.holla@arm.com \
--cc=thara.gopinath@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).