* [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN
@ 2021-11-12 9:37 Lukas Bulwahn
2021-11-15 21:38 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2021-11-12 9:37 UTC (permalink / raw)
To: Jens Axboe, Tejun Heo, linux-block
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit cd006509b0a9 ("blk-iocost: account for IO size when testing
latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in
config BLK_CGROUP_IOCOST.
Hence, ./scripts/checkkconfigsymbols.py warns:
BLK_RQ_IO_DATA_LEN
Referencing files: block/Kconfig
Probably, this select is just some unintended left-over from an earlier
draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the
repository. So, drop this dead select to an undefined config.
Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
block/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/Kconfig b/block/Kconfig
index c6ce41a5e5b2..486bc6003b9e 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -133,7 +133,6 @@ config BLK_CGROUP_FC_APPID
config BLK_CGROUP_IOCOST
bool "Enable support for cost model based cgroup IO controller"
depends on BLK_CGROUP
- select BLK_RQ_IO_DATA_LEN
select BLK_RQ_ALLOC_TIME
help
Enabling this option enables the .weight interface for cost
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN
2021-11-12 9:37 [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN Lukas Bulwahn
@ 2021-11-15 21:38 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2021-11-15 21:38 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: Jens Axboe, linux-block, kernel-janitors, linux-kernel
On Fri, Nov 12, 2021 at 10:37:28AM +0100, Lukas Bulwahn wrote:
> Commit cd006509b0a9 ("blk-iocost: account for IO size when testing
> latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in
> config BLK_CGROUP_IOCOST.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> BLK_RQ_IO_DATA_LEN
> Referencing files: block/Kconfig
>
> Probably, this select is just some unintended left-over from an earlier
> draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the
> repository. So, drop this dead select to an undefined config.
>
> Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-16 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 9:37 [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN Lukas Bulwahn
2021-11-15 21:38 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).