* [PATCH] platform/x86: dell-wmi-descriptor: disable by default
@ 2021-11-13 8:05 Thomas Weißschuh
2021-11-16 9:58 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weißschuh @ 2021-11-13 8:05 UTC (permalink / raw)
To: Hans de Goede, Mark Gross, Mario Limonciello,
platform-driver-x86, Dell.Client.Kernel
Cc: Thomas Weißschuh, linux-kernel
dell-wmi-descriptor only provides symbols to other drivers.
These drivers already select dell-wmi-descriptor when needed.
This fixes an issue where dell-wmi-descriptor is compiled as a module
with localyesconfig on a non-Dell machine.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/platform/x86/dell/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
index 821aba31821c..dbc71a936339 100644
--- a/drivers/platform/x86/dell/Kconfig
+++ b/drivers/platform/x86/dell/Kconfig
@@ -187,7 +187,7 @@ config DELL_WMI_AIO
config DELL_WMI_DESCRIPTOR
tristate
- default m
+ default n
depends on ACPI_WMI
config DELL_WMI_LED
base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: dell-wmi-descriptor: disable by default
2021-11-13 8:05 [PATCH] platform/x86: dell-wmi-descriptor: disable by default Thomas Weißschuh
@ 2021-11-16 9:58 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-11-16 9:58 UTC (permalink / raw)
To: Thomas Weißschuh, Mark Gross, Mario Limonciello,
platform-driver-x86, Dell.Client.Kernel
Cc: linux-kernel
Hi,
On 11/13/21 09:05, Thomas Weißschuh wrote:
> dell-wmi-descriptor only provides symbols to other drivers.
> These drivers already select dell-wmi-descriptor when needed.
>
> This fixes an issue where dell-wmi-descriptor is compiled as a module
> with localyesconfig on a non-Dell machine.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/dell/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
> index 821aba31821c..dbc71a936339 100644
> --- a/drivers/platform/x86/dell/Kconfig
> +++ b/drivers/platform/x86/dell/Kconfig
> @@ -187,7 +187,7 @@ config DELL_WMI_AIO
>
> config DELL_WMI_DESCRIPTOR
> tristate
> - default m
> + default n
> depends on ACPI_WMI
>
> config DELL_WMI_LED
>
> base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-16 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-13 8:05 [PATCH] platform/x86: dell-wmi-descriptor: disable by default Thomas Weißschuh
2021-11-16 9:58 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).