* [PATCH v4] mips: bcm63xx: add support for clk_get_parent()
@ 2021-11-15 0:42 Randy Dunlap
2021-11-15 4:18 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-11-15 0:42 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Russell King, Artur Rojek,
Paul Cercueil, linux-mips, Jonathan Cameron, Lars-Peter Clausen,
linux-iio, Florian Fainelli, Andy Shevchenko, Russell King,
bcm-kernel-feedback-list, Jonas Gorski, Jonathan Cameron
BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
clk_get_parent(), so add a simple implementation of that
function so that callers of it will build without errors.
Fixes these build errors:
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Cc: Artur Rojek <contact@artur-rojek.eu>
Cc: Paul Cercueil <paul@crapouillou.net>
Cc: linux-mips@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
v1 and v2 were:
[PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
(limiting this driver to MACH_INGENIC in Kconfig)
v3: add clk_get_parent() to arch/mips/bcm63xx/clk.c
v4:
add Fixes:, Suggested-by:, Reviewed-by: Acked-by:
drop blank line between function and EXPORT_SYMBOL(); (Andy)
arch/mips/bcm63xx/clk.c | 7 +++++++
1 file changed, 7 insertions(+)
--- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
+++ linux-next-20211112/arch/mips/bcm63xx/clk.c
@@ -381,6 +381,12 @@ void clk_disable(struct clk *clk)
EXPORT_SYMBOL(clk_disable);
+struct clk *clk_get_parent(struct clk *clk)
+{
+ return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
unsigned long clk_get_rate(struct clk *clk)
{
if (!clk)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v4] mips: bcm63xx: add support for clk_get_parent()
2021-11-15 0:42 [PATCH v4] mips: bcm63xx: add support for clk_get_parent() Randy Dunlap
@ 2021-11-15 4:18 ` Florian Fainelli
2021-11-15 10:56 ` Andy Shevchenko
2021-11-16 8:46 ` Thomas Bogendoerfer
2 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2021-11-15 4:18 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: kernel test robot, Russell King, Artur Rojek, Paul Cercueil,
linux-mips, Jonathan Cameron, Lars-Peter Clausen, linux-iio,
Andy Shevchenko, Russell King, bcm-kernel-feedback-list,
Jonas Gorski, Jonathan Cameron
On 11/14/2021 4:42 PM, Randy Dunlap wrote:
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Cc: Artur Rojek <contact@artur-rojek.eu>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: linux-mips@vger.kernel.org
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: linux-iio@vger.kernel.org
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: Jonas Gorski <jonas.gorski@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v4] mips: bcm63xx: add support for clk_get_parent()
2021-11-15 0:42 [PATCH v4] mips: bcm63xx: add support for clk_get_parent() Randy Dunlap
2021-11-15 4:18 ` Florian Fainelli
@ 2021-11-15 10:56 ` Andy Shevchenko
2021-11-16 6:19 ` Randy Dunlap
2021-11-16 8:46 ` Thomas Bogendoerfer
2 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2021-11-15 10:56 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kernel Mailing List, kernel test robot,
open list:BROADCOM NVRAM DRIVER, linux-iio,
bcm-kernel-feedback-list
On Mon, Nov 15, 2021 at 2:42 AM Randy Dunlap <rdunlap@infradead.org> wrote:
Just couple of side notes on the same topic (dropped people from Cc,
just MLs are left):
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
1/ `git format-patch`/`git send-email` will create the Cc list from
all known tags, hence no need to repeat people in Cc.
2/ Consider to use --cc and --to to avoid burden on the git history
(sometimes people want to see it on mobile devices).
For myself I wrote the script [1] to give me some smartness. Maybe you
can find some ideas inside its implementation.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] mips: bcm63xx: add support for clk_get_parent()
2021-11-15 10:56 ` Andy Shevchenko
@ 2021-11-16 6:19 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-11-16 6:19 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linux Kernel Mailing List, kernel test robot,
open list:BROADCOM NVRAM DRIVER, linux-iio,
bcm-kernel-feedback-list
On 11/15/21 2:56 AM, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 2:42 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Just couple of side notes on the same topic (dropped people from Cc,
> just MLs are left):
>
>> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
>> Cc: Jonathan Cameron <jic23@kernel.org>
>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Russell King <linux@armlinux.org.uk>
>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> 1/ `git format-patch`/`git send-email` will create the Cc list from
> all known tags, hence no need to repeat people in Cc.
> 2/ Consider to use --cc and --to to avoid burden on the git history
> (sometimes people want to see it on mobile devices).
>
> For myself I wrote the script [1] to give me some smartness. Maybe you
> can find some ideas inside its implementation.
>
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
OK, I'll look into that.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] mips: bcm63xx: add support for clk_get_parent()
2021-11-15 0:42 [PATCH v4] mips: bcm63xx: add support for clk_get_parent() Randy Dunlap
2021-11-15 4:18 ` Florian Fainelli
2021-11-15 10:56 ` Andy Shevchenko
@ 2021-11-16 8:46 ` Thomas Bogendoerfer
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Bogendoerfer @ 2021-11-16 8:46 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Russell King, Artur Rojek,
Paul Cercueil, linux-mips, Jonathan Cameron, Lars-Peter Clausen,
linux-iio, Florian Fainelli, Andy Shevchenko, Russell King,
bcm-kernel-feedback-list, Jonas Gorski, Jonathan Cameron
On Sun, Nov 14, 2021 at 04:42:18PM -0800, Randy Dunlap wrote:
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs." )
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Cc: Artur Rojek <contact@artur-rojek.eu>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: linux-mips@vger.kernel.org
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: linux-iio@vger.kernel.org
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: Jonas Gorski <jonas.gorski@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> v1 and v2 were:
> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
> (limiting this driver to MACH_INGENIC in Kconfig)
> v3: add clk_get_parent() to arch/mips/bcm63xx/clk.c
> v4:
> add Fixes:, Suggested-by:, Reviewed-by: Acked-by:
> drop blank line between function and EXPORT_SYMBOL(); (Andy)
>
> arch/mips/bcm63xx/clk.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
> @@ -381,6 +381,12 @@ void clk_disable(struct clk *clk)
>
> EXPORT_SYMBOL(clk_disable);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> + return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
> unsigned long clk_get_rate(struct clk *clk)
> {
> if (!clk)
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-16 8:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 0:42 [PATCH v4] mips: bcm63xx: add support for clk_get_parent() Randy Dunlap
2021-11-15 4:18 ` Florian Fainelli
2021-11-15 10:56 ` Andy Shevchenko
2021-11-16 6:19 ` Randy Dunlap
2021-11-16 8:46 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).