linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mips: lantiq: add support for clk_get_parent()
@ 2021-11-15  1:20 Randy Dunlap
  2021-11-15 17:51 ` Jonathan Cameron
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-11-15  1:20 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Russell King, linux-mips, John Crispin,
	Thomas Bogendoerfer, Jonathan Cameron, linux-iio, Russell King,
	Andy Shevchenko

Provide a simple implementation of clk_get_parent() in the
lantiq subarch so that callers of it will build without errors.

Fixes this build error:
ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!

Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Cc: linux-mips@vger.kernel.org
Cc: John Crispin <john@phrozen.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org
Cc: Russell King <linux@armlinux.org.uk>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 arch/mips/lantiq/clk.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- linux-next-20211112.orig/arch/mips/lantiq/clk.c
+++ linux-next-20211112/arch/mips/lantiq/clk.c
@@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
 }
 EXPORT_SYMBOL(clk_deactivate);
 
+struct clk *clk_get_parent(struct clk *clk)
+{
+	return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
 static inline u32 get_counter_resolution(void)
 {
 	u32 res;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mips: lantiq: add support for clk_get_parent()
  2021-11-15  1:20 [PATCH] mips: lantiq: add support for clk_get_parent() Randy Dunlap
@ 2021-11-15 17:51 ` Jonathan Cameron
  2021-11-15 17:58 ` John Crispin
  2021-11-16  8:46 ` Thomas Bogendoerfer
  2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2021-11-15 17:51 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Russell King, linux-mips, John Crispin,
	Thomas Bogendoerfer, Jonathan Cameron, linux-iio, Russell King,
	Andy Shevchenko

On Sun, 14 Nov 2021 17:20:51 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> Provide a simple implementation of clk_get_parent() in the
> lantiq subarch so that callers of it will build without errors.
> 
> Fixes this build error:
> ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!
> 
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Cc: linux-mips@vger.kernel.org
> Cc: John Crispin <john@phrozen.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio@vger.kernel.org
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks for tidying this up.

Jonathan

> ---
>  arch/mips/lantiq/clk.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> --- linux-next-20211112.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211112/arch/mips/lantiq/clk.c
> @@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
>  }
>  EXPORT_SYMBOL(clk_deactivate);
>  
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> +	return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
>  static inline u32 get_counter_resolution(void)
>  {
>  	u32 res;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mips: lantiq: add support for clk_get_parent()
  2021-11-15  1:20 [PATCH] mips: lantiq: add support for clk_get_parent() Randy Dunlap
  2021-11-15 17:51 ` Jonathan Cameron
@ 2021-11-15 17:58 ` John Crispin
  2021-11-16  8:46 ` Thomas Bogendoerfer
  2 siblings, 0 replies; 4+ messages in thread
From: John Crispin @ 2021-11-15 17:58 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: Russell King, linux-mips, Thomas Bogendoerfer, Jonathan Cameron,
	linux-iio, Russell King, Andy Shevchenko



On 15.11.21 02:20, Randy Dunlap wrote:
> Provide a simple implementation of clk_get_parent() in the
> lantiq subarch so that callers of it will build without errors.
> 
> Fixes this build error:
> ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!
> 
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Cc: linux-mips@vger.kernel.org
> Cc: John Crispin <john@phrozen.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio@vger.kernel.org
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>

Acked-by: John Crispin <john@phrozen.org>

// we added the same fix for mips/ralink a while back

> ---
>   arch/mips/lantiq/clk.c |    6 ++++++
>   1 file changed, 6 insertions(+)
> 
> --- linux-next-20211112.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211112/arch/mips/lantiq/clk.c
> @@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
>   }
>   EXPORT_SYMBOL(clk_deactivate);
>   
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> +	return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
>   static inline u32 get_counter_resolution(void)
>   {
>   	u32 res;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mips: lantiq: add support for clk_get_parent()
  2021-11-15  1:20 [PATCH] mips: lantiq: add support for clk_get_parent() Randy Dunlap
  2021-11-15 17:51 ` Jonathan Cameron
  2021-11-15 17:58 ` John Crispin
@ 2021-11-16  8:46 ` Thomas Bogendoerfer
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2021-11-16  8:46 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Russell King, linux-mips, John Crispin,
	Jonathan Cameron, linux-iio, Russell King, Andy Shevchenko

On Sun, Nov 14, 2021 at 05:20:51PM -0800, Randy Dunlap wrote:
> Provide a simple implementation of clk_get_parent() in the
> lantiq subarch so that callers of it will build without errors.
> 
> Fixes this build error:
> ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!
> 
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Cc: linux-mips@vger.kernel.org
> Cc: John Crispin <john@phrozen.org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio@vger.kernel.org
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>  arch/mips/lantiq/clk.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> --- linux-next-20211112.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211112/arch/mips/lantiq/clk.c
> @@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
>  }
>  EXPORT_SYMBOL(clk_deactivate);
>  
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> +	return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
>  static inline u32 get_counter_resolution(void)
>  {
>  	u32 res;

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-16  8:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15  1:20 [PATCH] mips: lantiq: add support for clk_get_parent() Randy Dunlap
2021-11-15 17:51 ` Jonathan Cameron
2021-11-15 17:58 ` John Crispin
2021-11-16  8:46 ` Thomas Bogendoerfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).