* arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types)
@ 2021-11-15 4:55 kernel test robot
2021-11-15 7:58 ` [PATCH] ARM: mm: mark private VM_FAULT_X defines as vm_fault_t Kefeng Wang
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-11-15 4:55 UTC (permalink / raw)
To: Wang Kefeng; +Cc: kbuild-all, linux-kernel, Russell King (Oracle)
[-- Attachment #1: Type: text/plain, Size: 4267 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8ab774587903771821b59471cc723bba6d893942
commit: caed89dab0ca0e73d7e016c04e1f5957650f4ec3 ARM: 9128/1: mm: Refactor the __do_page_fault()
date: 4 weeks ago
config: arm-randconfig-s031-20211115 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=caed89dab0ca0e73d7e016c04e1f5957650f4ec3
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout caed89dab0ca0e73d7e016c04e1f5957650f4ec3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:210:24: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:210:24: sparse: got int
arch/arm/mm/fault.c:214:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:214:32: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:214:32: sparse: got int
arch/arm/mm/fault.c:216:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:216:32: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:216:32: sparse: got int
arch/arm/mm/fault.c:218:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:218:32: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:218:32: sparse: got int
arch/arm/mm/fault.c:226:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:226:24: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:226:24: sparse: got int
arch/arm/mm/fault.c:312:13: sparse: sparse: restricted vm_fault_t degrades to integer
arch/arm/mm/fault.c:312:13: sparse: sparse: restricted vm_fault_t degrades to integer
arch/arm/mm/fault.c:345:24: sparse: sparse: restricted vm_fault_t degrades to integer
arch/arm/mm/fault.c:510:1: sparse: sparse: symbol 'do_DataAbort' was not declared. Should it be static?
arch/arm/mm/fault.c:540:1: sparse: sparse: symbol 'do_PrefetchAbort' was not declared. Should it be static?
vim +210 arch/arm/mm/fault.c
202
203 static vm_fault_t __kprobes
204 __do_page_fault(struct mm_struct *mm, unsigned long addr, unsigned int fsr,
205 unsigned int flags, struct task_struct *tsk,
206 struct pt_regs *regs)
207 {
208 struct vm_area_struct *vma = find_vma(mm, addr);
209 if (unlikely(!vma))
> 210 return VM_FAULT_BADMAP;
211
212 if (unlikely(vma->vm_start > addr)) {
213 if (!(vma->vm_flags & VM_GROWSDOWN))
214 return VM_FAULT_BADMAP;
215 if (addr < FIRST_USER_ADDRESS)
216 return VM_FAULT_BADMAP;
217 if (expand_stack(vma, addr))
218 return VM_FAULT_BADMAP;
219 }
220
221 /*
222 * Ok, we have a good vm_area for this
223 * memory access, so we can handle it.
224 */
225 if (access_error(fsr, vma))
226 return VM_FAULT_BADACCESS;
227
228 return handle_mm_fault(vma, addr & PAGE_MASK, flags, regs);
229 }
230
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30056 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: mm: mark private VM_FAULT_X defines as vm_fault_t
2021-11-15 4:55 arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types) kernel test robot
@ 2021-11-15 7:58 ` Kefeng Wang
0 siblings, 0 replies; 4+ messages in thread
From: Kefeng Wang @ 2021-11-15 7:58 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel
Cc: Kefeng Wang, kernel test robot
This fixes several sparse warnings for fault.c:
arch/arm/mm/fault.c:210:24: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:210:24: sparse: got int
...
arch/arm/mm/fault.c:345:24: sparse: sparse: restricted vm_fault_t degrades to integer
Reported-by: kernel test robot <lkp@intel.com>
Fixes: caed89dab0ca ("ARM: 9128/1: mm: Refactor the __do_page_fault()")
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
arch/arm/mm/fault.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
index bc8779d54a64..013921a5909b 100644
--- a/arch/arm/mm/fault.c
+++ b/arch/arm/mm/fault.c
@@ -191,8 +191,8 @@ void do_bad_area(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
}
#ifdef CONFIG_MMU
-#define VM_FAULT_BADMAP 0x010000
-#define VM_FAULT_BADACCESS 0x020000
+#define VM_FAULT_BADMAP ((__force vm_fault_t)0x010000)
+#define VM_FAULT_BADACCESS ((__force vm_fault_t)0x020000)
static inline bool is_permission_fault(unsigned int fsr)
{
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types)
2021-11-16 20:14 arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types) kernel test robot
@ 2021-11-17 2:15 ` Kefeng Wang
0 siblings, 0 replies; 4+ messages in thread
From: Kefeng Wang @ 2021-11-17 2:15 UTC (permalink / raw)
To: kernel test robot; +Cc: kbuild-all, linux-kernel, Russell King (Oracle)
https://lore.kernel.org/linux-arm-kernel/20211115075834.156838-1-wangkefeng.wang@huawei.com/
On 2021/11/17 4:14, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 8ab774587903771821b59471cc723bba6d893942
> commit: caed89dab0ca0e73d7e016c04e1f5957650f4ec3 ARM: 9128/1: mm: Refactor the __do_page_fault()
> date: 4 weeks ago
> config: arm-randconfig-s031-20211116 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=caed89dab0ca0e73d7e016c04e1f5957650f4ec3
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout caed89dab0ca0e73d7e016c04e1f5957650f4ec3
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mm/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>>> arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
> arch/arm/mm/fault.c:210:24: sparse: expected restricted vm_fault_t
> arch/arm/mm/fault.c:210:24: sparse: got int
> arch/arm/mm/fault.c:214:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
> arch/arm/mm/fault.c:214:32: sparse: expected restricted vm_fault_t
> arch/arm/mm/fault.c:214:32: sparse: got int
> arch/arm/mm/fault.c:216:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
> arch/arm/mm/fault.c:216:32: sparse: expected restricted vm_fault_t
> arch/arm/mm/fault.c:216:32: sparse: got int
> arch/arm/mm/fault.c:218:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
> arch/arm/mm/fault.c:218:32: sparse: expected restricted vm_fault_t
> arch/arm/mm/fault.c:218:32: sparse: got int
> arch/arm/mm/fault.c:226:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
> arch/arm/mm/fault.c:226:24: sparse: expected restricted vm_fault_t
> arch/arm/mm/fault.c:226:24: sparse: got int
> arch/arm/mm/fault.c:312:13: sparse: sparse: restricted vm_fault_t degrades to integer
> arch/arm/mm/fault.c:312:13: sparse: sparse: restricted vm_fault_t degrades to integer
> arch/arm/mm/fault.c:345:24: sparse: sparse: restricted vm_fault_t degrades to integer
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types)
@ 2021-11-16 20:14 kernel test robot
2021-11-17 2:15 ` Kefeng Wang
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-11-16 20:14 UTC (permalink / raw)
To: Wang Kefeng; +Cc: kbuild-all, linux-kernel, Russell King (Oracle)
[-- Attachment #1: Type: text/plain, Size: 4049 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8ab774587903771821b59471cc723bba6d893942
commit: caed89dab0ca0e73d7e016c04e1f5957650f4ec3 ARM: 9128/1: mm: Refactor the __do_page_fault()
date: 4 weeks ago
config: arm-randconfig-s031-20211116 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=caed89dab0ca0e73d7e016c04e1f5957650f4ec3
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout caed89dab0ca0e73d7e016c04e1f5957650f4ec3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:210:24: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:210:24: sparse: got int
arch/arm/mm/fault.c:214:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:214:32: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:214:32: sparse: got int
arch/arm/mm/fault.c:216:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:216:32: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:216:32: sparse: got int
arch/arm/mm/fault.c:218:32: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:218:32: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:218:32: sparse: got int
arch/arm/mm/fault.c:226:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted vm_fault_t @@ got int @@
arch/arm/mm/fault.c:226:24: sparse: expected restricted vm_fault_t
arch/arm/mm/fault.c:226:24: sparse: got int
arch/arm/mm/fault.c:312:13: sparse: sparse: restricted vm_fault_t degrades to integer
arch/arm/mm/fault.c:312:13: sparse: sparse: restricted vm_fault_t degrades to integer
arch/arm/mm/fault.c:345:24: sparse: sparse: restricted vm_fault_t degrades to integer
vim +210 arch/arm/mm/fault.c
202
203 static vm_fault_t __kprobes
204 __do_page_fault(struct mm_struct *mm, unsigned long addr, unsigned int fsr,
205 unsigned int flags, struct task_struct *tsk,
206 struct pt_regs *regs)
207 {
208 struct vm_area_struct *vma = find_vma(mm, addr);
209 if (unlikely(!vma))
> 210 return VM_FAULT_BADMAP;
211
212 if (unlikely(vma->vm_start > addr)) {
213 if (!(vma->vm_flags & VM_GROWSDOWN))
214 return VM_FAULT_BADMAP;
215 if (addr < FIRST_USER_ADDRESS)
216 return VM_FAULT_BADMAP;
217 if (expand_stack(vma, addr))
218 return VM_FAULT_BADMAP;
219 }
220
221 /*
222 * Ok, we have a good vm_area for this
223 * memory access, so we can handle it.
224 */
225 if (access_error(fsr, vma))
226 return VM_FAULT_BADACCESS;
227
228 return handle_mm_fault(vma, addr & PAGE_MASK, flags, regs);
229 }
230
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35550 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-17 2:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 4:55 arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types) kernel test robot
2021-11-15 7:58 ` [PATCH] ARM: mm: mark private VM_FAULT_X defines as vm_fault_t Kefeng Wang
2021-11-16 20:14 arch/arm/mm/fault.c:210:24: sparse: sparse: incorrect type in return expression (different base types) kernel test robot
2021-11-17 2:15 ` Kefeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).