* [PATCH v2 1/2] Add binding for IIO ADS1018
@ 2021-11-16 15:58 Iain Hunter
2021-11-17 2:27 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Iain Hunter @ 2021-11-16 15:58 UTC (permalink / raw)
Cc: iain, Iain Hunter, Jonathan Cameron, Lars-Peter Clausen,
Rob Herring, linux-iio, devicetree, linux-kernel
v2 has me as suggested maintainer per Daniel's feedback.
Signed-off-by: Iain Hunter <drhunter95@gmail.com>
---
.../bindings/iio/adc/ti,ads1018.yaml | 109 ++++++++++++++++++
1 file changed, 109 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
new file mode 100644
index 000000000000..bd7421f882a8
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
@@ -0,0 +1,109 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/ti,ads1015.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI ADS1018 4 channel I2C analog to digital converter
+
+maintainers:
+ - Iain Hunter <iain@hunterembedded.co.uk>
+
+description: |
+ Datasheet at: https://www.ti.com/lit/gpn/ads1018
+ Supports both single ended and differential channels.
+
+properties:
+ compatible:
+ const: ti,ads1018
+
+ reg:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ "#io-channel-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+
+additionalProperties: false
+
+patternProperties:
+ "^channel@[0-7]+$":
+ type: object
+ description:
+ Child nodes needed for each channel that the platform uses.
+
+ properties:
+ reg:
+ description: |
+ 0: Voltage over AIN0 and AIN1.
+ 1: Voltage over AIN0 and AIN3.
+ 2: Voltage over AIN1 and AIN3.
+ 3: Voltage over AIN2 and AIN3.
+ 4: Voltage over AIN0 and GND.
+ 5: Voltage over AIN1 and GND.
+ 6: Voltage over AIN2 and GND.
+ 7: Voltage over AIN3 and GND.
+ items:
+ - minimum: 0
+ maximum: 7
+
+ ti,gain:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 5
+ description: |
+ pga is the programmable gain amplifier (values are full scale)
+ 0: +/- 6.144 V
+ 1: +/- 4.096 V
+ 2: +/- 2.048 V (default)
+ 3: +/- 1.024 V
+ 4: +/- 0.512 V
+ 5: +/- 0.256 V
+
+ ti,datarate:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 6
+ description: |
+ Data acquisition rate in samples per second
+ 0: 128
+ 1: 250
+ 2: 490
+ 3: 920
+ 4: 1600 (default)
+ 5: 2400
+ 6: 3300
+
+ required:
+ - reg
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ adc@1 {
+ compatible = "ti,ads1018";
+ reg = <0x1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ channel@4 {
+ reg = <4>;
+ ti,gain = <3>;
+ ti,datarate = <5>;
+ };
+ };
+ };
+...
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] Add binding for IIO ADS1018
2021-11-16 15:58 [PATCH v2 1/2] Add binding for IIO ADS1018 Iain Hunter
@ 2021-11-17 2:27 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-11-17 2:27 UTC (permalink / raw)
To: Iain Hunter
Cc: Rob Herring, Lars-Peter Clausen, Jonathan Cameron, linux-kernel,
devicetree, iain, linux-iio
On Tue, 16 Nov 2021 15:58:58 +0000, Iain Hunter wrote:
> v2 has me as suggested maintainer per Daniel's feedback.
>
> Signed-off-by: Iain Hunter <drhunter95@gmail.com>
> ---
> .../bindings/iio/adc/ti,ads1018.yaml | 109 ++++++++++++++++++
> 1 file changed, 109 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/iio/adc/ti,ads1018.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml: duplicate '$id' value 'http://devicetree.org/schemas/iio/adc/ti,ads1015.yaml#'
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1555907
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-17 2:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 15:58 [PATCH v2 1/2] Add binding for IIO ADS1018 Iain Hunter
2021-11-17 2:27 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).