* [PATCH] cpufreq: intel_pstate: ITMT support for overclocked system
@ 2021-11-19 5:18 Srinivas Pandruvada
2021-11-19 11:19 ` Michael Larabel
0 siblings, 1 reply; 4+ messages in thread
From: Srinivas Pandruvada @ 2021-11-19 5:18 UTC (permalink / raw)
To: lenb, rafael, viresh.kumar
Cc: linux-kernel, linux-pm, ricardo.neri, tim.c.chen, peterz,
Michael, arjan, Srinivas Pandruvada
On systems with overclocking enabled, CPPC Highest Performance can be
hard coded to 0xff. In this case even if we have cores with different
highest performance, ITMT can't be enabled as the current implementation
depends on CPPC Highest Performance.
On such systems we can use MSR_HWP_CAPABILITIES maximum performance field
when CPPC.Highest Performance is 0xff.
Due to legacy reasons, we can't solely depend on MSR_HWP_CAPABILITIES as
in some older systems CPPC Highest Performance is the only way to identify
different performing cores.
Reported-by: Michael Larabel <Michael@MichaelLarabel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
This patch was tested on one Alder Lake system by enabling Overclocking.
Once overclocking is enabled, we see
$cat /sys/devices/system/cpu/cpu*/acpi_cppc/highest_perf
255 (P-Cores)
255 (P-Cores
...
...
255 (E-Cores)
255 (E-Cores)
The real max performance for CPUs on this system was
0x40 for P-cores and 0x26 for E-cores.
With this change applied we will see
$cat /proc/sys/kernel/sched_itmt_enabled
1
The resultant ITMT priorities
for P-core 0x40, P-core HT sibling 0x10 and E-core 0x26
drivers/cpufreq/intel_pstate.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 815df3daae9d..3106e62ffb25 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -338,6 +338,8 @@ static void intel_pstste_sched_itmt_work_fn(struct work_struct *work)
static DECLARE_WORK(sched_itmt_work, intel_pstste_sched_itmt_work_fn);
+#define CPPC_MAX_PERF U8_MAX
+
static void intel_pstate_set_itmt_prio(int cpu)
{
struct cppc_perf_caps cppc_perf;
@@ -348,6 +350,14 @@ static void intel_pstate_set_itmt_prio(int cpu)
if (ret)
return;
+ /*
+ * On some systems with overclocking enabled, CPPC.highest_perf is hardcoded to 0xff.
+ * In this case we can't use CPPC.highest_perf to enable ITMT.
+ * In this case we can look at MSR_HWP_CAPABILITIES bits [8:0] to decide.
+ */
+ if (cppc_perf.highest_perf == CPPC_MAX_PERF)
+ cppc_perf.highest_perf = HWP_HIGHEST_PERF(READ_ONCE(all_cpu_data[cpu]->hwp_cap_cached));
+
/*
* The priorities can be set regardless of whether or not
* sched_set_itmt_support(true) has been called and it is valid to
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: ITMT support for overclocked system
2021-11-19 5:18 [PATCH] cpufreq: intel_pstate: ITMT support for overclocked system Srinivas Pandruvada
@ 2021-11-19 11:19 ` Michael Larabel
2021-11-19 13:27 ` Srinivas Pandruvada
0 siblings, 1 reply; 4+ messages in thread
From: Michael Larabel @ 2021-11-19 11:19 UTC (permalink / raw)
To: Srinivas Pandruvada, lenb, rafael, viresh.kumar
Cc: linux-kernel, linux-pm, ricardo.neri, tim.c.chen, peterz, arjan
On 11/18/21 23:18, Srinivas Pandruvada wrote:
> On systems with overclocking enabled, CPPC Highest Performance can be
> hard coded to 0xff. In this case even if we have cores with different
> highest performance, ITMT can't be enabled as the current implementation
> depends on CPPC Highest Performance.
>
> On such systems we can use MSR_HWP_CAPABILITIES maximum performance field
> when CPPC.Highest Performance is 0xff.
>
> Due to legacy reasons, we can't solely depend on MSR_HWP_CAPABILITIES as
> in some older systems CPPC Highest Performance is the only way to identify
> different performing cores.
>
> Reported-by: Michael Larabel <Michael@MichaelLarabel.com>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> This patch was tested on one Alder Lake system by enabling Overclocking.
> Once overclocking is enabled, we see
> $cat /sys/devices/system/cpu/cpu*/acpi_cppc/highest_perf
> 255 (P-Cores)
> 255 (P-Cores
> ...
> ...
> 255 (E-Cores)
> 255 (E-Cores)
> The real max performance for CPUs on this system was
> 0x40 for P-cores and 0x26 for E-cores.
> With this change applied we will see
> $cat /proc/sys/kernel/sched_itmt_enabled
> 1
> The resultant ITMT priorities
> for P-core 0x40, P-core HT sibling 0x10 and E-core 0x26
With this patch I can confirm that now sched_itmt_enabled = 1 and
correct highest_perf with the ASUS ROG STRIX Z690-E GAMING WIFI board on
the latest BIOS. Thanks.
Tested-by: Michael Larabel <Michael@MichaelLarabel.com>
Michael
>
> drivers/cpufreq/intel_pstate.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 815df3daae9d..3106e62ffb25 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -338,6 +338,8 @@ static void intel_pstste_sched_itmt_work_fn(struct work_struct *work)
>
> static DECLARE_WORK(sched_itmt_work, intel_pstste_sched_itmt_work_fn);
>
> +#define CPPC_MAX_PERF U8_MAX
> +
> static void intel_pstate_set_itmt_prio(int cpu)
> {
> struct cppc_perf_caps cppc_perf;
> @@ -348,6 +350,14 @@ static void intel_pstate_set_itmt_prio(int cpu)
> if (ret)
> return;
>
> + /*
> + * On some systems with overclocking enabled, CPPC.highest_perf is hardcoded to 0xff.
> + * In this case we can't use CPPC.highest_perf to enable ITMT.
> + * In this case we can look at MSR_HWP_CAPABILITIES bits [8:0] to decide.
> + */
> + if (cppc_perf.highest_perf == CPPC_MAX_PERF)
> + cppc_perf.highest_perf = HWP_HIGHEST_PERF(READ_ONCE(all_cpu_data[cpu]->hwp_cap_cached));
> +
> /*
> * The priorities can be set regardless of whether or not
> * sched_set_itmt_support(true) has been called and it is valid to
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: ITMT support for overclocked system
2021-11-19 11:19 ` Michael Larabel
@ 2021-11-19 13:27 ` Srinivas Pandruvada
2021-11-23 13:13 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Srinivas Pandruvada @ 2021-11-19 13:27 UTC (permalink / raw)
To: Michael Larabel, lenb, rafael, viresh.kumar
Cc: linux-kernel, linux-pm, ricardo.neri, tim.c.chen, peterz, arjan
On Fri, 2021-11-19 at 05:19 -0600, Michael Larabel wrote:
> On 11/18/21 23:18, Srinivas Pandruvada wrote:
> > On systems with overclocking enabled, CPPC Highest Performance can
> > be
> > hard coded to 0xff. In this case even if we have cores with
> > different
> > highest performance, ITMT can't be enabled as the current
> > implementation
> > depends on CPPC Highest Performance.
> >
> > On such systems we can use MSR_HWP_CAPABILITIES maximum performance
> > field
> > when CPPC.Highest Performance is 0xff.
> >
> > Due to legacy reasons, we can't solely depend on
> > MSR_HWP_CAPABILITIES as
> > in some older systems CPPC Highest Performance is the only way to
> > identify
> > different performing cores.
> >
> > Reported-by: Michael Larabel <Michael@MichaelLarabel.com>
> > Signed-off-by: Srinivas Pandruvada <
> > srinivas.pandruvada@linux.intel.com>
> > ---
> > This patch was tested on one Alder Lake system by enabling
> > Overclocking.
> > Once overclocking is enabled, we see
> > $cat /sys/devices/system/cpu/cpu*/acpi_cppc/highest_perf
> > 255 (P-Cores)
> > 255 (P-Cores
> > ...
> > ...
> > 255 (E-Cores)
> > 255 (E-Cores)
> > The real max performance for CPUs on this system was
> > 0x40 for P-cores and 0x26 for E-cores.
> > With this change applied we will see
> > $cat /proc/sys/kernel/sched_itmt_enabled
> > 1
> > The resultant ITMT priorities
> > for P-core 0x40, P-core HT sibling 0x10 and E-core 0x26
>
>
> With this patch I can confirm that now sched_itmt_enabled = 1 and
> correct highest_perf with the ASUS ROG STRIX Z690-E GAMING WIFI board
> on
> the latest BIOS. Thanks.
>
> Tested-by: Michael Larabel <Michael@MichaelLarabel.com>
>
Thanks Michael for confirming.
-Srinivas
> Michael
>
>
> >
> > drivers/cpufreq/intel_pstate.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/cpufreq/intel_pstate.c
> > b/drivers/cpufreq/intel_pstate.c
> > index 815df3daae9d..3106e62ffb25 100644
> > --- a/drivers/cpufreq/intel_pstate.c
> > +++ b/drivers/cpufreq/intel_pstate.c
> > @@ -338,6 +338,8 @@ static void
> > intel_pstste_sched_itmt_work_fn(struct work_struct *work)
> >
> > static DECLARE_WORK(sched_itmt_work,
> > intel_pstste_sched_itmt_work_fn);
> >
> > +#define CPPC_MAX_PERF U8_MAX
> > +
> > static void intel_pstate_set_itmt_prio(int cpu)
> > {
> > struct cppc_perf_caps cppc_perf;
> > @@ -348,6 +350,14 @@ static void intel_pstate_set_itmt_prio(int
> > cpu)
> > if (ret)
> > return;
> >
> > + /*
> > + * On some systems with overclocking enabled,
> > CPPC.highest_perf is hardcoded to 0xff.
> > + * In this case we can't use CPPC.highest_perf to enable
> > ITMT.
> > + * In this case we can look at MSR_HWP_CAPABILITIES bits
> > [8:0] to decide.
> > + */
> > + if (cppc_perf.highest_perf == CPPC_MAX_PERF)
> > + cppc_perf.highest_perf =
> > HWP_HIGHEST_PERF(READ_ONCE(all_cpu_data[cpu]->hwp_cap_cached));
> > +
> > /*
> > * The priorities can be set regardless of whether or not
> > * sched_set_itmt_support(true) has been called and it is
> > valid to
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: ITMT support for overclocked system
2021-11-19 13:27 ` Srinivas Pandruvada
@ 2021-11-23 13:13 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-11-23 13:13 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Michael Larabel, Len Brown, Rafael J. Wysocki, Viresh Kumar,
Linux Kernel Mailing List, Linux PM, Neri, Ricardo, tim.c.chen,
Peter Zijlstra, Arjan van de Ven
On Fri, Nov 19, 2021 at 2:28 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> On Fri, 2021-11-19 at 05:19 -0600, Michael Larabel wrote:
> > On 11/18/21 23:18, Srinivas Pandruvada wrote:
> > > On systems with overclocking enabled, CPPC Highest Performance can
> > > be
> > > hard coded to 0xff. In this case even if we have cores with
> > > different
> > > highest performance, ITMT can't be enabled as the current
> > > implementation
> > > depends on CPPC Highest Performance.
> > >
> > > On such systems we can use MSR_HWP_CAPABILITIES maximum performance
> > > field
> > > when CPPC.Highest Performance is 0xff.
> > >
> > > Due to legacy reasons, we can't solely depend on
> > > MSR_HWP_CAPABILITIES as
> > > in some older systems CPPC Highest Performance is the only way to
> > > identify
> > > different performing cores.
> > >
> > > Reported-by: Michael Larabel <Michael@MichaelLarabel.com>
> > > Signed-off-by: Srinivas Pandruvada <
> > > srinivas.pandruvada@linux.intel.com>
> > > ---
> > > This patch was tested on one Alder Lake system by enabling
> > > Overclocking.
> > > Once overclocking is enabled, we see
> > > $cat /sys/devices/system/cpu/cpu*/acpi_cppc/highest_perf
> > > 255 (P-Cores)
> > > 255 (P-Cores
> > > ...
> > > ...
> > > 255 (E-Cores)
> > > 255 (E-Cores)
> > > The real max performance for CPUs on this system was
> > > 0x40 for P-cores and 0x26 for E-cores.
> > > With this change applied we will see
> > > $cat /proc/sys/kernel/sched_itmt_enabled
> > > 1
> > > The resultant ITMT priorities
> > > for P-core 0x40, P-core HT sibling 0x10 and E-core 0x26
> >
> >
> > With this patch I can confirm that now sched_itmt_enabled = 1 and
> > correct highest_perf with the ASUS ROG STRIX Z690-E GAMING WIFI board
> > on
> > the latest BIOS. Thanks.
> >
> > Tested-by: Michael Larabel <Michael@MichaelLarabel.com>
> >
>
> Thanks Michael for confirming.
Applied as 5.16-rc3 material, thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-23 13:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19 5:18 [PATCH] cpufreq: intel_pstate: ITMT support for overclocked system Srinivas Pandruvada
2021-11-19 11:19 ` Michael Larabel
2021-11-19 13:27 ` Srinivas Pandruvada
2021-11-23 13:13 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).