* [PATCH] staging: vt6655: rename variable bHWRadioOff
@ 2021-11-21 11:19 Alberto Merciai
2021-11-23 20:08 ` Tommaso Merciai
2021-11-23 22:15 ` Tommaso Merciai
0 siblings, 2 replies; 3+ messages in thread
From: Alberto Merciai @ 2021-11-21 11:19 UTC (permalink / raw)
To: alb3rt0.m3rciai
Cc: Forest Bond, Greg Kroah-Hartman, Tommaso Merciai, Dan Carpenter,
Aldas Taraškevičius, Karolina Drobnik,
Gustavo A. R. Silva, Lucas Henneman, linux-staging, linux-kernel
Replace camelcase hungarian notated variable "bHWRadioOff"
into linux kernel coding style equivalent variable "hw_radio_off".
Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
---
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index ff171acc11f4..e9d1b56d8809 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -229,7 +229,7 @@ struct vnt_private {
/* GPIO Radio Control */
unsigned char byRadioCtl;
unsigned char byGPIO;
- bool bHWRadioOff;
+ bool hw_radio_off;
bool bPrvActive4RadioOFF;
bool bGPIOBlockRead;
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 1f98f2b069c4..897d70cf32b8 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -373,7 +373,7 @@ static void device_init_registers(struct vnt_private *priv)
priv->byRadioCtl = SROMbyReadEmbedded(priv->port_offset,
EEP_OFS_RADIOCTL);
- priv->bHWRadioOff = false;
+ priv->hw_radio_off = false;
if (priv->byRadioCtl & EEP_RADIOCTL_ENABLE) {
/* Get GPIO */
@@ -383,10 +383,10 @@ static void device_init_registers(struct vnt_private *priv)
!(priv->byRadioCtl & EEP_RADIOCTL_INV)) ||
(!(priv->byGPIO & GPIO0_DATA) &&
(priv->byRadioCtl & EEP_RADIOCTL_INV)))
- priv->bHWRadioOff = true;
+ priv->hw_radio_off = true;
}
- if (priv->bHWRadioOff || priv->bRadioControlOff)
+ if (priv->hw_radio_off || priv->bRadioControlOff)
CARDbRadioPowerOff(priv);
/* get Permanent network address */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: vt6655: rename variable bHWRadioOff
2021-11-21 11:19 [PATCH] staging: vt6655: rename variable bHWRadioOff Alberto Merciai
@ 2021-11-23 20:08 ` Tommaso Merciai
2021-11-23 22:15 ` Tommaso Merciai
1 sibling, 0 replies; 3+ messages in thread
From: Tommaso Merciai @ 2021-11-23 20:08 UTC (permalink / raw)
To: Alberto Merciai
Cc: Forest Bond, Greg Kroah-Hartman, Dan Carpenter,
Aldas Taraškevičius, Karolina Drobnik,
Gustavo A. R. Silva, Lucas Henneman, linux-staging, linux-kernel
On Sun, Nov 21, 2021 at 12:19:59PM +0100, Alberto Merciai wrote:
> Replace camelcase hungarian notated variable "bHWRadioOff"
> into linux kernel coding style equivalent variable "hw_radio_off".
>
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
> ---
> drivers/staging/vt6655/device.h | 2 +-
> drivers/staging/vt6655/device_main.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index ff171acc11f4..e9d1b56d8809 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -229,7 +229,7 @@ struct vnt_private {
> /* GPIO Radio Control */
> unsigned char byRadioCtl;
> unsigned char byGPIO;
> - bool bHWRadioOff;
> + bool hw_radio_off;
> bool bPrvActive4RadioOFF;
> bool bGPIOBlockRead;
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 1f98f2b069c4..897d70cf32b8 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -373,7 +373,7 @@ static void device_init_registers(struct vnt_private *priv)
>
> priv->byRadioCtl = SROMbyReadEmbedded(priv->port_offset,
> EEP_OFS_RADIOCTL);
> - priv->bHWRadioOff = false;
> + priv->hw_radio_off = false;
>
> if (priv->byRadioCtl & EEP_RADIOCTL_ENABLE) {
> /* Get GPIO */
> @@ -383,10 +383,10 @@ static void device_init_registers(struct vnt_private *priv)
> !(priv->byRadioCtl & EEP_RADIOCTL_INV)) ||
> (!(priv->byGPIO & GPIO0_DATA) &&
> (priv->byRadioCtl & EEP_RADIOCTL_INV)))
> - priv->bHWRadioOff = true;
> + priv->hw_radio_off = true;
> }
>
> - if (priv->bHWRadioOff || priv->bRadioControlOff)
> + if (priv->hw_radio_off || priv->bRadioControlOff)
> CARDbRadioPowerOff(priv);
>
> /* get Permanent network address */
> --
> 2.25.1
>
Look's okay.
Acked-by: Tommaso Merciai <tommaso.merciai@gmail.com>
Regards,
Tommaso
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: vt6655: rename variable bHWRadioOff
2021-11-21 11:19 [PATCH] staging: vt6655: rename variable bHWRadioOff Alberto Merciai
2021-11-23 20:08 ` Tommaso Merciai
@ 2021-11-23 22:15 ` Tommaso Merciai
1 sibling, 0 replies; 3+ messages in thread
From: Tommaso Merciai @ 2021-11-23 22:15 UTC (permalink / raw)
To: Alberto Merciai
Cc: Forest Bond, Greg Kroah-Hartman, Dan Carpenter,
Aldas Taraškevičius, Karolina Drobnik,
Gustavo A. R. Silva, Lucas Henneman, linux-staging, linux-kernel
On Sun, Nov 21, 2021 at 12:19:59PM +0100, Alberto Merciai wrote:
> Replace camelcase hungarian notated variable "bHWRadioOff"
> into linux kernel coding style equivalent variable "hw_radio_off".
>
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
> ---
> drivers/staging/vt6655/device.h | 2 +-
> drivers/staging/vt6655/device_main.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index ff171acc11f4..e9d1b56d8809 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -229,7 +229,7 @@ struct vnt_private {
> /* GPIO Radio Control */
> unsigned char byRadioCtl;
> unsigned char byGPIO;
> - bool bHWRadioOff;
> + bool hw_radio_off;
> bool bPrvActive4RadioOFF;
> bool bGPIOBlockRead;
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 1f98f2b069c4..897d70cf32b8 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -373,7 +373,7 @@ static void device_init_registers(struct vnt_private *priv)
>
> priv->byRadioCtl = SROMbyReadEmbedded(priv->port_offset,
> EEP_OFS_RADIOCTL);
> - priv->bHWRadioOff = false;
> + priv->hw_radio_off = false;
>
> if (priv->byRadioCtl & EEP_RADIOCTL_ENABLE) {
> /* Get GPIO */
> @@ -383,10 +383,10 @@ static void device_init_registers(struct vnt_private *priv)
> !(priv->byRadioCtl & EEP_RADIOCTL_INV)) ||
> (!(priv->byGPIO & GPIO0_DATA) &&
> (priv->byRadioCtl & EEP_RADIOCTL_INV)))
> - priv->bHWRadioOff = true;
> + priv->hw_radio_off = true;
> }
>
> - if (priv->bHWRadioOff || priv->bRadioControlOff)
> + if (priv->hw_radio_off || priv->bRadioControlOff)
> CARDbRadioPowerOff(priv);
>
> /* get Permanent network address */
> --
> 2.25.1
>
Hi,
Sorry, bad mail address on acked by. Meanwhile I test the build.
It's look's fine too.
Acked-by: Tommaso Merciai <tomm.merciai@gmail.com>
Tested-by: Tommaso Merciai <tomm.merciai@gmail.com>
Regards,
Tommaso
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-23 22:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-21 11:19 [PATCH] staging: vt6655: rename variable bHWRadioOff Alberto Merciai
2021-11-23 20:08 ` Tommaso Merciai
2021-11-23 22:15 ` Tommaso Merciai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).