From: SeongJae Park <sj@kernel.org>
To: Xin Hao <xhao@linux.alibaba.com>
Cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/2] mm/damon: move damon_rand definition into damon.h
Date: Sun, 21 Nov 2021 11:33:12 +0000 [thread overview]
Message-ID: <20211121113312.3942-1-sj@kernel.org> (raw)
In-Reply-To: <6a4a7e53c2ab99028d431e7dc5e3d7635adb8522.1637429074.git.xhao@linux.alibaba.com>
Hi Xin,
On Sun, 21 Nov 2021 01:27:54 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:
> damon_rand() is called in three files:damon/core.c, damon/
> paddr.c, damon/vaddr.c, i think there is no need to redefine
> this twice, So move it to damon.h will be a good choice.
Good finding. Could you please append '()' after 'damon_rand' in the title
(s/damon_rand definition/damon_rand() definition)?
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
After doing that, you could add
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> include/linux/damon.h | 4 ++++
> mm/damon/core.c | 4 ----
> mm/damon/prmtv-common.h | 4 ----
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index 8a73e825e0d5..8706b17a9acf 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -11,12 +11,16 @@
> #include <linux/mutex.h>
> #include <linux/time64.h>
> #include <linux/types.h>
> +#include <linux/random.h>
>
> /* Minimal region size. Every damon_region is aligned by this. */
> #define DAMON_MIN_REGION PAGE_SIZE
> /* Max priority score for DAMON-based operation schemes */
> #define DAMOS_MAX_SCORE (99)
>
> +/* Get a random number in [l, r) */
> +#define damon_rand(l, r) (l + prandom_u32_max(r - l))
> +
> /**
> * struct damon_addr_range - Represents an address region of [@start, @end).
> * @start: Start address of the region (inclusive).
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 4d2c3a0c7c8a..bdec32ef78c0 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -11,7 +11,6 @@
> #include <linux/delay.h>
> #include <linux/kthread.h>
> #include <linux/mm.h>
> -#include <linux/random.h>
> #include <linux/slab.h>
> #include <linux/string.h>
>
> @@ -23,9 +22,6 @@
> #define DAMON_MIN_REGION 1
> #endif
>
> -/* Get a random number in [l, r) */
> -#define damon_rand(l, r) (l + prandom_u32_max(r - l))
> -
> static DEFINE_MUTEX(damon_lock);
> static int nr_running_ctxs;
>
> diff --git a/mm/damon/prmtv-common.h b/mm/damon/prmtv-common.h
> index 61f27037603e..e790cb5f8fe0 100644
> --- a/mm/damon/prmtv-common.h
> +++ b/mm/damon/prmtv-common.h
> @@ -6,10 +6,6 @@
> */
>
> #include <linux/damon.h>
> -#include <linux/random.h>
> -
> -/* Get a random number in [l, r) */
> -#define damon_rand(l, r) (l + prandom_u32_max(r - l))
>
> struct page *damon_get_page(unsigned long pfn);
>
> --
> 2.31.0
>
>
next prev parent reply other threads:[~2021-11-21 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 17:27 [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig Xin Hao
2021-11-20 17:27 ` [PATCH V1 2/2] mm/damon: move damon_rand definition into damon.h Xin Hao
2021-11-21 11:33 ` SeongJae Park [this message]
2021-11-21 13:20 ` Xin Hao
2021-11-21 11:24 ` [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig SeongJae Park
2021-11-21 13:19 ` Xin Hao
2021-11-26 3:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211121113312.3942-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).