From: Xin Hao <xhao@linux.alibaba.com>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig
Date: Sun, 21 Nov 2021 21:19:57 +0800 [thread overview]
Message-ID: <32a90a3d-5cf6-66cc-fa3b-19753a057052@linux.alibaba.com> (raw)
In-Reply-To: <20211121112417.33255-1-sj@kernel.org>
Hi Park,
On 11/21/21 7:24 PM, SeongJae Park wrote:
> Hi Xin,
>
> On Sun, 21 Nov 2021 01:27:53 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:
>
>> If you want to support "DAMON_DBGFS" in config file, it only depends on
>> any one of "DAMON_VADDR" and "DAMON_PADDR".
> This is not true. DAMON_DBGFS really depends on both.
>
> This patch even makes the build fails with some configs.
>
> CC mm/damon/dbgfs.o
> linux/mm/damon/dbgfs.c: In function ‘dbgfs_target_ids_write’:
> linux/mm/damon/dbgfs.c:409:3: error: implicit declaration of function ‘damon_pa_set_primitives’; did you mean ‘damon_va_set_primitives’? [-Werror=implicit-function-declaration]
> damon_pa_set_primitives(ctx);
> ^~~~~~~~~~~~~~~~~~~~~~~
> damon_va_set_primitives
> cc1: some warnings being treated as errors
That is my fault, i have found a solution, and i will send a v2 patch
to solve it, i I think DAMON_VADDR and DAMON_PADDR
must be decoupled,the kconfig must support it, becasue sometimes i don't
want to use damon paddr function, just only need to include
DAMON_VADDR, therefore, it is not necessary to include damon/paddr.c
during compile time.
>
>
> Thanks,
> SJ
>
>> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
>> ---
>> mm/damon/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
>> index 5bcf05851ad0..971ffc496596 100644
>> --- a/mm/damon/Kconfig
>> +++ b/mm/damon/Kconfig
>> @@ -54,7 +54,7 @@ config DAMON_VADDR_KUNIT_TEST
>>
>> config DAMON_DBGFS
>> bool "DAMON debugfs interface"
>> - depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS
>> + depends on DAMON_VADDR || DAMON_PADDR && DEBUG_FS
>> help
>> This builds the debugfs interface for DAMON. The user space admins
>> can use the interface for arbitrary data access monitoring.
>> --
>> 2.31.0
>>
>>
--
Best Regards!
Xin Hao
next prev parent reply other threads:[~2021-11-21 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 17:27 [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig Xin Hao
2021-11-20 17:27 ` [PATCH V1 2/2] mm/damon: move damon_rand definition into damon.h Xin Hao
2021-11-21 11:33 ` SeongJae Park
2021-11-21 13:20 ` Xin Hao
2021-11-21 11:24 ` [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig SeongJae Park
2021-11-21 13:19 ` Xin Hao [this message]
2021-11-26 3:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a90a3d-5cf6-66cc-fa3b-19753a057052@linux.alibaba.com \
--to=xhao@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).