* [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq' static
@ 2021-11-23 8:36 Wei Yongjun
2021-11-23 12:45 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-11-23 8:36 UTC (permalink / raw)
To: weiyongjun1, Ioanna Alifieraki, Corey Minyard
Cc: openipmi-developer, linux-kernel, kernel-janitors, Hulk Robot
The sparse tool complains as follows:
drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
symbol 'remove_work_wq' was not declared. Should it be static?
This symbol is not used outside of ipmi_msghandler.c, so
marks it static.
Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 1ade72bfae0f..a2ec0171363a 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -191,7 +191,7 @@ struct ipmi_user {
struct work_struct remove_work;
};
-struct workqueue_struct *remove_work_wq;
+static struct workqueue_struct *remove_work_wq;
static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
__acquires(user->release_barrier)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq' static
2021-11-23 8:36 [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq' static Wei Yongjun
@ 2021-11-23 12:45 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2021-11-23 12:45 UTC (permalink / raw)
To: Wei Yongjun
Cc: Ioanna Alifieraki, openipmi-developer, linux-kernel,
kernel-janitors, Hulk Robot
On Tue, Nov 23, 2021 at 08:36:18AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
> symbol 'remove_work_wq' was not declared. Should it be static?
>
> This symbol is not used outside of ipmi_msghandler.c, so
> marks it static.
Thanks, I should have noticed this.
-corey
>
> Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 1ade72bfae0f..a2ec0171363a 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -191,7 +191,7 @@ struct ipmi_user {
> struct work_struct remove_work;
> };
>
> -struct workqueue_struct *remove_work_wq;
> +static struct workqueue_struct *remove_work_wq;
>
> static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
> __acquires(user->release_barrier)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-23 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 8:36 [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq' static Wei Yongjun
2021-11-23 12:45 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).