From: Oleksij Rempel <o.rempel@pengutronix.de>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-iio@vger.kernel.org,
Robin van der Gracht <robin@protonic.nl>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v1] counter: interrupt-cnt: add counter_push_event()
Date: Wed, 24 Nov 2021 08:27:20 +0100 [thread overview]
Message-ID: <20211124072720.GA30281@pengutronix.de> (raw)
In-Reply-To: <YZ3XAeYyfGblfaOi@shinobu>
Hi William,
On Wed, Nov 24, 2021 at 03:09:05PM +0900, William Breathitt Gray wrote:
> On Tue, Nov 23, 2021 at 02:45:40PM +0100, Oleksij Rempel wrote:
> > Add counter_push_event() to notify user space about new pulses
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > drivers/counter/interrupt-cnt.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
> > index 8514a87fcbee..b237137b552b 100644
> > --- a/drivers/counter/interrupt-cnt.c
> > +++ b/drivers/counter/interrupt-cnt.c
> > @@ -31,6 +31,8 @@ static irqreturn_t interrupt_cnt_isr(int irq, void *dev_id)
> >
> > atomic_inc(&priv->count);
> >
> > + counter_push_event(&priv->counter, COUNTER_EVENT_OVERFLOW, 0);
> > +
> > return IRQ_HANDLED;
> > }
> >
> > --
> > 2.30.2
>
> Hi Oleksij,
>
> It looks like this is pushing a COUNTER_EVENT_OVERFLOW event every time
> an interrupt is handled, which I suspect is not what you want to happen.
> The COUNTER_EVENT_OVERFLOW event indicates a count value overflow event,
> so you'll need to check for a count value overflow before pushing the
> event.
>
> It would be good idea to implement a ceiling extension as well (you can
> use the COUNTER_COMP_CEILING() macro) so that users can configure the
> particular point where the value overflows.
Thank you!
What would be the best and resource effective strategy for periodically
getting frequency of interrupts/pulses? This is actual information which is
needed for my use case.
So far, I was pushing every event to the user space, which is working
but probably not the most resource effective method of doing it.
Regards,
Oleskij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-11-24 7:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 13:45 [PATCH v1] counter: interrupt-cnt: add counter_push_event() Oleksij Rempel
2021-11-24 6:09 ` William Breathitt Gray
2021-11-24 7:27 ` Oleksij Rempel [this message]
2021-11-25 1:58 ` William Breathitt Gray
2021-11-25 7:27 ` David Jander
2021-12-06 19:24 ` David Lechner
2021-12-07 7:16 ` David Jander
2021-12-08 13:59 ` Uwe Kleine-König
2021-12-08 16:10 ` David Jander
2021-12-15 8:48 ` William Breathitt Gray
2021-12-15 9:08 ` David Jander
2021-12-25 4:07 ` William Breathitt Gray
2021-12-27 15:16 ` David Lechner
2021-12-29 9:26 ` William Breathitt Gray
2021-12-29 16:45 ` Jonathan Cameron
2022-02-02 12:32 ` Oleksij Rempel
2022-02-02 15:17 ` David Lechner
2022-02-03 7:24 ` Oleksij Rempel
2022-02-03 7:50 ` William Breathitt Gray
2022-02-03 10:40 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124072720.GA30281@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=david@protonic.nl \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin@protonic.nl \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).