From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
Robin van der Gracht <robin@protonic.nl>,
linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v1] counter: interrupt-cnt: add counter_push_event()
Date: Wed, 24 Nov 2021 15:09:05 +0900 [thread overview]
Message-ID: <YZ3XAeYyfGblfaOi@shinobu> (raw)
In-Reply-To: <20211123134540.416695-1-o.rempel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
On Tue, Nov 23, 2021 at 02:45:40PM +0100, Oleksij Rempel wrote:
> Add counter_push_event() to notify user space about new pulses
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/counter/interrupt-cnt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
> index 8514a87fcbee..b237137b552b 100644
> --- a/drivers/counter/interrupt-cnt.c
> +++ b/drivers/counter/interrupt-cnt.c
> @@ -31,6 +31,8 @@ static irqreturn_t interrupt_cnt_isr(int irq, void *dev_id)
>
> atomic_inc(&priv->count);
>
> + counter_push_event(&priv->counter, COUNTER_EVENT_OVERFLOW, 0);
> +
> return IRQ_HANDLED;
> }
>
> --
> 2.30.2
Hi Oleksij,
It looks like this is pushing a COUNTER_EVENT_OVERFLOW event every time
an interrupt is handled, which I suspect is not what you want to happen.
The COUNTER_EVENT_OVERFLOW event indicates a count value overflow event,
so you'll need to check for a count value overflow before pushing the
event.
It would be good idea to implement a ceiling extension as well (you can
use the COUNTER_COMP_CEILING() macro) so that users can configure the
particular point where the value overflows.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-24 6:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 13:45 [PATCH v1] counter: interrupt-cnt: add counter_push_event() Oleksij Rempel
2021-11-24 6:09 ` William Breathitt Gray [this message]
2021-11-24 7:27 ` Oleksij Rempel
2021-11-25 1:58 ` William Breathitt Gray
2021-11-25 7:27 ` David Jander
2021-12-06 19:24 ` David Lechner
2021-12-07 7:16 ` David Jander
2021-12-08 13:59 ` Uwe Kleine-König
2021-12-08 16:10 ` David Jander
2021-12-15 8:48 ` William Breathitt Gray
2021-12-15 9:08 ` David Jander
2021-12-25 4:07 ` William Breathitt Gray
2021-12-27 15:16 ` David Lechner
2021-12-29 9:26 ` William Breathitt Gray
2021-12-29 16:45 ` Jonathan Cameron
2022-02-02 12:32 ` Oleksij Rempel
2022-02-02 15:17 ` David Lechner
2022-02-03 7:24 ` Oleksij Rempel
2022-02-03 7:50 ` William Breathitt Gray
2022-02-03 10:40 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ3XAeYyfGblfaOi@shinobu \
--to=vilhelm.gray@gmail.com \
--cc=david@protonic.nl \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).