[PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds

[PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds

[David Heidelberg]

Both are already used by HW and drivers inside Linux.

Fix warnings as:
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
        From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../devicetree/bindings/net/ethernet-controller.yaml          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index b0933a8c295a..95b5a3d77421 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -178,7 +178,7 @@ properties:
                   Duplex configuration. 0 for half duplex or 1 for
                   full duplex
 
-              - enum: [10, 100, 1000]
+              - enum: [10, 100, 1000, 2500, 10000]
                 description:
                   Link speed in Mbits/sec.
 
@@ -200,7 +200,7 @@ properties:
               description:
                 Link speed.
               $ref: /schemas/types.yaml#/definitions/uint32
-              enum: [10, 100, 1000]
+              enum: [10, 100, 1000, 2500, 10000]
 
             full-duplex:
               $ref: /schemas/types.yaml#/definitions/flag
-- 
2.33.0

Re: [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds

[Andrew Lunn]

On Wed, Nov 24, 2021 at 09:20:46PM +0100, David Heidelberg wrote:
> Both are already used by HW and drivers inside Linux.
> 
> Fix warnings as:
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
>         From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

This is valid for the binding, but not all Linux implementations of
fixed-link support > 1G. Only the phylink one does. But that is
outside the scope of the binding document.

You probably should list all speeds in
drivers/net/phy/phy-core.c:phy_setting settings[]. They are all valid
when using phylink and fixed-link.

	Andrew

Re: [PATCH] dt-bindings: net: ethernet-controller: add 2.5G and 10G speeds

[Rob Herring]

On Wed, 24 Nov 2021 21:20:46 +0100, David Heidelberg wrote:
> Both are already used by HW and drivers inside Linux.
> 
> Fix warnings as:
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dt.yaml: ethernet@0,2: fixed-link:speed:0:0: 2500 is not one of [10, 100, 1000]
>         From schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../devicetree/bindings/net/ethernet-controller.yaml          | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks!