linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset
@ 2021-11-25 15:20 Geert Uytterhoeven
  2021-11-26  0:01 ` Damien Le Moal
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-11-25 15:20 UTC (permalink / raw)
  To: Eugeniy Paltsev, Vinod Koul, Rob Herring, Heng Sia, Damien Le Moal
  Cc: dmaengine, devicetree, linux-riscv, linux-kernel, Geert Uytterhoeven

"make dtbs_check":

    Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
    arch/riscv/boot/dts/canaan/sipeed_maix_bit.dt.yaml: dma-controller@50000000: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
	    From schema: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml

The Synopsys DesignWare AXI DMA Controller on the Canaan K210 SoC
exposes its reset signal.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 90d9274e5464e396..06ddffaada295171 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -53,6 +53,9 @@ properties:
     minimum: 1
     maximum: 8
 
+  resets:
+    maxItems: 1
+
   snps,dma-masters:
     description: |
       Number of AXI masters supported by the hardware.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset
  2021-11-25 15:20 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset Geert Uytterhoeven
@ 2021-11-26  0:01 ` Damien Le Moal
  2021-12-01 22:44 ` Rob Herring
  2021-12-13  6:25 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2021-11-26  0:01 UTC (permalink / raw)
  To: Geert Uytterhoeven, Eugeniy Paltsev, Vinod Koul, Rob Herring, Heng Sia
  Cc: dmaengine, devicetree, linux-riscv, linux-kernel

On 2021/11/26 0:20, Geert Uytterhoeven wrote:
> "make dtbs_check":
> 
>     Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>     arch/riscv/boot/dts/canaan/sipeed_maix_bit.dt.yaml: dma-controller@50000000: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	    From schema: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> 
> The Synopsys DesignWare AXI DMA Controller on the Canaan K210 SoC
> exposes its reset signal.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 90d9274e5464e396..06ddffaada295171 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -53,6 +53,9 @@ properties:
>      minimum: 1
>      maximum: 8
>  
> +  resets:
> +    maxItems: 1
> +
>    snps,dma-masters:
>      description: |
>        Number of AXI masters supported by the hardware.
> 

Looks good to me.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset
  2021-11-25 15:20 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset Geert Uytterhoeven
  2021-11-26  0:01 ` Damien Le Moal
@ 2021-12-01 22:44 ` Rob Herring
  2021-12-13  6:25 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-12-01 22:44 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: linux-riscv, Heng Sia, Rob Herring, dmaengine, devicetree,
	Vinod Koul, linux-kernel, Damien Le Moal, Eugeniy Paltsev

On Thu, 25 Nov 2021 16:20:08 +0100, Geert Uytterhoeven wrote:
> "make dtbs_check":
> 
>     Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>     arch/riscv/boot/dts/canaan/sipeed_maix_bit.dt.yaml: dma-controller@50000000: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	    From schema: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> 
> The Synopsys DesignWare AXI DMA Controller on the Canaan K210 SoC
> exposes its reset signal.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset
  2021-11-25 15:20 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset Geert Uytterhoeven
  2021-11-26  0:01 ` Damien Le Moal
  2021-12-01 22:44 ` Rob Herring
@ 2021-12-13  6:25 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-12-13  6:25 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Eugeniy Paltsev, Rob Herring, Heng Sia, Damien Le Moal,
	dmaengine, devicetree, linux-riscv, linux-kernel

On 25-11-21, 16:20, Geert Uytterhoeven wrote:
> "make dtbs_check":
> 
>     Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>     arch/riscv/boot/dts/canaan/sipeed_maix_bit.dt.yaml: dma-controller@50000000: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	    From schema: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> 
> The Synopsys DesignWare AXI DMA Controller on the Canaan K210 SoC
> exposes its reset signal.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-13  6:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 15:20 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset Geert Uytterhoeven
2021-11-26  0:01 ` Damien Le Moal
2021-12-01 22:44 ` Rob Herring
2021-12-13  6:25 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).