* [PATCH] EDAC/sb_edac: Remove redundant initialization of variable rc
@ 2021-11-26 22:18 Colin Ian King
2021-12-21 11:07 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-11-26 22:18 UTC (permalink / raw)
To: Tony Luck, Qiuxu Zhuo, Borislav Petkov, Mauro Carvalho Chehab,
James Morse, Robert Richter, linux-edac
Cc: kernel-janitors, linux-kernel
The variable rc is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/edac/sb_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 1522d4aa2ca6..9678ab97c7ac 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -3439,7 +3439,7 @@ MODULE_DEVICE_TABLE(x86cpu, sbridge_cpuids);
static int sbridge_probe(const struct x86_cpu_id *id)
{
- int rc = -ENODEV;
+ int rc;
u8 mc, num_mc = 0;
struct sbridge_dev *sbridge_dev;
struct pci_id_table *ptable = (struct pci_id_table *)id->driver_data;
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] EDAC/sb_edac: Remove redundant initialization of variable rc
2021-11-26 22:18 [PATCH] EDAC/sb_edac: Remove redundant initialization of variable rc Colin Ian King
@ 2021-12-21 11:07 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2021-12-21 11:07 UTC (permalink / raw)
To: Colin Ian King
Cc: Tony Luck, Qiuxu Zhuo, Mauro Carvalho Chehab, James Morse,
Robert Richter, linux-edac, kernel-janitors, linux-kernel
On Fri, Nov 26, 2021 at 10:18:48PM +0000, Colin Ian King wrote:
> The variable rc is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/edac/sb_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 1522d4aa2ca6..9678ab97c7ac 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -3439,7 +3439,7 @@ MODULE_DEVICE_TABLE(x86cpu, sbridge_cpuids);
>
> static int sbridge_probe(const struct x86_cpu_id *id)
> {
> - int rc = -ENODEV;
> + int rc;
> u8 mc, num_mc = 0;
> struct sbridge_dev *sbridge_dev;
> struct pci_id_table *ptable = (struct pci_id_table *)id->driver_data;
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-21 11:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 22:18 [PATCH] EDAC/sb_edac: Remove redundant initialization of variable rc Colin Ian King
2021-12-21 11:07 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).