* kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
@ 2021-11-26 18:01 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-11-26 18:01 UTC (permalink / raw)
To: Daniel Bristot de Oliveira
Cc: kbuild-all, linux-kernel, Steven Rostedt (VMware)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a4849f6000e29235a2707f22e39da6b897bb9543
commit: 498627b4ac85780b9962ed9b5c5abbefd884ef8e trace/osnoise: Fix return value on osnoise_init_hotplug_support
date: 5 months ago
config: i386-randconfig-s002-20211118 (https://download.01.org/0day-ci/archive/20211127/202111270153.j3tgBvDJ-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=498627b4ac85780b9962ed9b5c5abbefd884ef8e
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 498627b4ac85780b9962ed9b5c5abbefd884ef8e
# save the config file to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash kernel/trace/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/trace/trace_osnoise.c:108:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static?
>> kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:223:14: sparse: sparse: symbol 'interface_lock' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1766:5: sparse: sparse: symbol 'timerlat_min_period' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1767:5: sparse: sparse: symbol 'timerlat_max_period' was not declared. Should it be static?
vim +/__pcpu_scope_per_cpu_timerlat_var +131 kernel/trace/trace_osnoise.c
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 112 */
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 113 static inline struct osnoise_variables *this_cpu_osn_var(void)
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 114 {
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 115 return this_cpu_ptr(&per_cpu_osnoise_var);
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 116 }
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 117
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 118 #ifdef CONFIG_TIMERLAT_TRACER
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 119 /*
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 120 * Runtime information for the timer mode.
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 121 */
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 122 struct timerlat_variables {
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 123 struct task_struct *kthread;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 124 struct hrtimer timer;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 125 u64 rel_period;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 126 u64 abs_period;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 127 bool tracing_thread;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 128 u64 count;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 129 };
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 130
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 @131 DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var);
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 132
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 133 /*
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 134 * this_cpu_tmr_var - Return the per-cpu timerlat_variables on its relative CPU
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 135 */
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 136 static inline struct timerlat_variables *this_cpu_tmr_var(void)
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22 137 {
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 138 return this_cpu_ptr(&per_cpu_timerlat_var);
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 139 }
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 140
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 141 /*
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 142 * tlat_var_reset - Reset the values of the given timerlat_variables
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 143 */
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 144 static inline void tlat_var_reset(void)
:::::: The code at line 131 was first introduced by commit
:::::: a955d7eac1779b437ceb24fc352026a2cbcec140 trace: Add timerlat tracer
:::::: TO: Daniel Bristot de Oliveira <bristot@redhat.com>
:::::: CC: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
@ 2022-07-12 4:38 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-07-12 4:38 UTC (permalink / raw)
To: Daniel Bristot de Oliveira
Cc: kbuild-all, linux-kernel, Steven Rostedt (VMware)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5a29232d870d9e63fe5ff30b081be6ea7cc2465d
commit: a955d7eac1779b437ceb24fc352026a2cbcec140 trace: Add timerlat tracer
date: 1 year, 1 month ago
config: s390-randconfig-s032-20220712 (https://download.01.org/0day-ci/archive/20220712/202207121205.3WDa90OI-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a955d7eac1779b437ceb24fc352026a2cbcec140
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a955d7eac1779b437ceb24fc352026a2cbcec140
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/trace/trace_osnoise.c:108:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static?
>> kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:223:14: sparse: sparse: symbol 'interface_lock' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:657:6: sparse: sparse: symbol 'osnoise_trace_irq_entry' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:680:6: sparse: sparse: symbol 'osnoise_trace_irq_exit' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:739:5: sparse: sparse: symbol 'hook_irq_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:771:6: sparse: sparse: symbol 'unhook_irq_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:788:6: sparse: sparse: symbol 'trace_softirq_entry_callback' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:811:6: sparse: sparse: symbol 'trace_softirq_exit_callback' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:953:1: sparse: sparse: symbol 'trace_sched_switch_callback' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:971:5: sparse: sparse: symbol 'hook_thread_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:988:6: sparse: sparse: symbol 'unhook_thread_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1000:6: sparse: sparse: symbol 'save_osn_sample_stats' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1015:6: sparse: sparse: symbol 'diff_osn_sample_stats' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1657:5: sparse: sparse: symbol 'timerlat_min_period' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1658:5: sparse: sparse: symbol 'timerlat_max_period' was not declared. Should it be static?
vim +/__pcpu_scope_per_cpu_timerlat_var +131 kernel/trace/trace_osnoise.c
112
113 /*
114 * osnoise_unregister_instance - unregister a registered trace instance
115 *
116 * Remove the trace_array *tr from the list of instances running
117 * osnoise/timerlat tracers.
118 */
119 static void osnoise_unregister_instance(struct trace_array *tr)
120 {
121 struct osnoise_instance *inst;
122 int found = 0;
123
124 /*
125 * register/unregister serialization is provided by trace's
126 * trace_types_lock.
127 */
128 lockdep_assert_held(&trace_types_lock);
129
130 list_for_each_entry_rcu(inst, &osnoise_instances, list) {
> 131 if (inst->tr == tr) {
132 list_del_rcu(&inst->list);
133 found = 1;
134 break;
135 }
136 }
137
138 if (!found)
139 return;
140
141 kvfree_rcu(inst);
142 }
143
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
* kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
@ 2022-04-26 21:08 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-04-26 21:08 UTC (permalink / raw)
To: Daniel Bristot de Oliveira
Cc: kbuild-all, linux-kernel, Steven Rostedt (VMware)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: cf424ef014ac30b0da27125dd1fbdf10b0d3a520
commit: a955d7eac1779b437ceb24fc352026a2cbcec140 trace: Add timerlat tracer
date: 10 months ago
config: parisc-randconfig-s031-20220425 (https://download.01.org/0day-ci/archive/20220427/202204270534.hS2vHyWX-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a955d7eac1779b437ceb24fc352026a2cbcec140
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a955d7eac1779b437ceb24fc352026a2cbcec140
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/trace/trace_osnoise.c:108:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static?
>> kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:223:14: sparse: sparse: symbol 'interface_lock' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:657:6: sparse: sparse: symbol 'osnoise_trace_irq_entry' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:680:6: sparse: sparse: symbol 'osnoise_trace_irq_exit' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:739:5: sparse: sparse: symbol 'hook_irq_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:771:6: sparse: sparse: symbol 'unhook_irq_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:788:6: sparse: sparse: symbol 'trace_softirq_entry_callback' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:811:6: sparse: sparse: symbol 'trace_softirq_exit_callback' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:953:1: sparse: sparse: symbol 'trace_sched_switch_callback' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:971:5: sparse: sparse: symbol 'hook_thread_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:988:6: sparse: sparse: symbol 'unhook_thread_events' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1000:6: sparse: sparse: symbol 'save_osn_sample_stats' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1015:6: sparse: sparse: symbol 'diff_osn_sample_stats' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1213:17: sparse: sparse: incompatible types in comparison expression (different signedness):
kernel/trace/trace_osnoise.c:1213:17: sparse: signed long long *
kernel/trace/trace_osnoise.c:1213:17: sparse: unsigned long long [usertype] *
kernel/trace/trace_osnoise.c:1657:5: sparse: sparse: symbol 'timerlat_min_period' was not declared. Should it be static?
kernel/trace/trace_osnoise.c:1658:5: sparse: sparse: symbol 'timerlat_max_period' was not declared. Should it be static?
vim +/__pcpu_scope_per_cpu_timerlat_var +131 kernel/trace/trace_osnoise.c
112
113 /*
114 * osnoise_unregister_instance - unregister a registered trace instance
115 *
116 * Remove the trace_array *tr from the list of instances running
117 * osnoise/timerlat tracers.
118 */
119 static void osnoise_unregister_instance(struct trace_array *tr)
120 {
121 struct osnoise_instance *inst;
122 int found = 0;
123
124 /*
125 * register/unregister serialization is provided by trace's
126 * trace_types_lock.
127 */
128 lockdep_assert_held(&trace_types_lock);
129
130 list_for_each_entry_rcu(inst, &osnoise_instances, list) {
> 131 if (inst->tr == tr) {
132 list_del_rcu(&inst->list);
133 found = 1;
134 break;
135 }
136 }
137
138 if (!found)
139 return;
140
141 kvfree_rcu(inst);
142 }
143
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-12 4:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 18:01 kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static? kernel test robot
2022-04-26 21:08 kernel test robot
2022-07-12 4:38 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).